Update getNodeDownloadUrl.ts #7242
Conversation
Signed-off-by: CodingRule <ioumih32@gmail.com>
|
If the comments are wrote wrongly please tell me! |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looking at the comparison, I think the switch statement is much cleaner.
There was a problem hiding this comment.
Any good paths I could take into making this better than the switch cases ? (;
There was a problem hiding this comment.
What's wrong with the switch statement?
There was a problem hiding this comment.
Yeah true ig.
Thx anyway for review
There was a problem hiding this comment.
No problem! Feel free to look at the issues tab for things that need to be fixed. "Help wanted" and "good first issue" are places to start.
There was a problem hiding this comment.
Looking at the comparison, I think the switch statement is much cleaner.
Same feeling
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Based on my comment above, I dont think this should land in its current form.
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
Not gonna lie, I actually was a fan of this PR, it looked way cleaner than the switch statement :)
Feel free to reopen it.
|
I'm still -1. I think that the switch statement is cleaner, but if you disagree, I won't block. |
4 participants
Technically the same thing I did to PR #7241