Skip to content

meta: skip lighthouse CI when no vercel preview detected #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmuenzenmeyer merged 1 commit into from
Nov 27, 2024
Merged

meta: skip lighthouse CI when no vercel preview detected #7266

bmuenzenmeyer merged 1 commit into from
Nov 27, 2024

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Nov 20, 2024

Description

This changes the Lighthouse CI to skip when a Vercel preview is not detected

Related Issues

#7253

@avivkeller
Update lighthouse.yml
5c8c29a 
Signed-off-by: Aviv Keller <redyetidev@gmail.com>
@avivkeller avivkeller requested a review from Copilot November 20, 2024 21:28
@avivkeller avivkeller requested a review from a team as a code owner November 20, 2024 21:28
@vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 20, 2024 9:28pm

@avivkeller
Copy link
Member Author

avivkeller commented Nov 20, 2024

The commit message didn't save 🤔, regardless, the PR title will be used, right? If not, feel free to force push and fix it.

Copilot AI reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@avivkeller
Copy link
Member Author

avivkeller commented Nov 20, 2024

image
Without a Vercel preview, the Lighthouse CI is skipped, as shown above.

AugustinMauroy
AugustinMauroy reviewed Nov 20, 2024
View reviewed changes
bmuenzenmeyer
bmuenzenmeyer reviewed Nov 21, 2024
View reviewed changes
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Nov 23, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 5.611s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 9202c36 Nov 27, 2024
15 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the chore/redyetidev/lighthouse-skip branch November 27, 2024 12:40
@avivkeller
Copy link
Member Author

avivkeller commented Dec 27, 2024

👋 follow-up #7361

@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Oct 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowd ovflowd ovflowd left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

Copilot code review Copilot Copilot left review comments

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avivkeller @bmuenzenmeyer @ovflowd @AugustinMauroy