fix: use tabindex when href is not available

[bjohansebas]

Description

Since a button is being simulated in the bottom component, a tabindex is added to buttons that don't have an href so they can be selected with the keyboard

Related Issues

closes #7247

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npm run format to ensure the code follows the style guide.
• I have run npm run test to check if all tests are passing.
• I have run npx turbo build to check if the website builds without errors.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Nov 20, 2024 11:20pm

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 95	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.79% (631/695)	72.65% (186/256)	94.53% (121/128)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
143	0 💤	0 ❌	0 🔥	5.385s ⏱️

[bmuenzenmeyer]

does hitting enter or spacebar work for anyone? this seems non-functional to me in

• chrome
• firefox

[bjohansebas]

Opps, it's not working because it's still a link. Maybe we should convert it into a real button instead of using it as a link

[bjohansebas]

Really, I would like to help, but running Next.js is too heavy for my computer

[bmuenzenmeyer]

I'm sorry to hear this but understand. The project has plenty of reasons to choose the stack we have, but I acknowledge (and have argued against) the complexity it brings.

We'll continue to aim for a balance of accessibility and capability, and it's my goal to make it more than lip service.

[ovflowd]

Really, I would like to help, but running Next.js is too heavy for my computer

I'm sorry to hear that. Could you tell me what exactly is too heavy? Is it consuming too much compute resources?

[bjohansebas]

Yep, too many resources consumed by Next.js, which makes the computer really slow.

When I have more resources, I'll come back here.