-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add CSS structure for country-specific style overrides (#7326) #7327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there are other languages need this change ?
I'm not certain if there are additional languages that would require these specific changes. However, implementing such functionality provides a pathway to address usability issues caused by linguistic differences. I believe this approach is neither excessive nor unnecessary, as it allows for improved accessibility and adaptability in a multilingual context. 🙏 |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Description
This PR introduces a CSS structure to support country-specific style overrides. The new structure allows defining localized styles efficiently while maintaining global consistency.
Validation
locals.css.line-height: 1.8,word-break: keep-all,word-wrap: break-word) are correctly applied when the HTMLlang='ko'attribute is present.lang='en') remain unchanged.Related Issues
Fixes #7326
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.