chore: document what we will/won’t translate #7350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
TRANSLATION.md:100
- The heading 'Why We Translate This section and Not this Section' should be 'Why We Translate This Section and Not This Section' for consistent capitalization.
## Why We Translate This section and Not this Section
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
thanks for putting this together.
i thought afterwards that this could also be a markdown table, but this is fine
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
bmuenzenmeyer
approved these changes
Dec 24, 2024
avivkeller
changed the title
Harkunwar
approved these changes
Dec 25, 2024
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Member
Author
|
Friendly ping @nodejs/tsc |
RafaelGSS
approved these changes
Dec 26, 2024
github-actions
bot
removed
the
github_actions:pull-request
Contributor
Unit Test Coverage Report
Unit Test Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People often ask why the learn section isn't translated, so I've written a bit of a document about it. But I'm not very good at the documentation part. So if anyone knows how to go over my work again, I think it would be beneficial.
The first review should be done by the website team and why not have it validated by the TSC?
Check List
npm run formatto ensure the code follows the style guide.