feat(InfoBox): introduce #7352
Merged
feat(InfoBox): introduce #7352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
reviewed
Dec 22, 2024
github-actions
bot
removed
the
github_actions:pull-request
Contributor
Unit Test Coverage Report
Unit Test Report
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ovflowd
reviewed
Dec 22, 2024
ovflowd
reviewed
Dec 22, 2024
ovflowd
reviewed
Dec 22, 2024
github-actions
bot
removed
the
github_actions:pull-request
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- apps/site/components/Common/InfoBox/index.module.css: Language not supported
Comments suppressed due to low confidence (4)
apps/site/components/Common/InfoBox/index.stories.tsx:12
- [nitpick] The title '3' is ambiguous. It should be renamed to a more descriptive title like 'Information'.
title: '3',
apps/site/components/Common/InfoBox/index.stories.tsx:22
- [nitpick] The title '2' is ambiguous. It should be renamed to a more descriptive title like 'Success'.
title: '2',
apps/site/components/Common/InfoBox/index.stories.tsx:32
- [nitpick] The title '1' is ambiguous. It should be renamed to a more descriptive title like 'Warning'.
title: '1',
apps/site/components/Common/InfoBox/index.stories.tsx:42
- [nitpick] The title '0' is ambiguous. It should be renamed to a more descriptive title like 'Error'.
title: '0',
AugustinMauroy
changed the title
ovflowd
reviewed
Dec 23, 2024
ovflowd
reviewed
Dec 23, 2024
github-actions
bot
removed
the
github_actions:pull-request
ovflowd
reviewed
Dec 23, 2024
ovflowd
approved these changes
Dec 24, 2024
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
I sometimes fail to understand your review process. We discussed "Alert" as a component naming and then you go and name it "AlertBox" 😅 -- Anyhow, fair enough.
LGTM and thanks for implementing this :)
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
we decided to make the
stabilityIndexcomponent a sub-component which is an InfoBox that can be used in the download page. also for thestabilityIndexcomponent it will just be a wrapper ofInfoBox.Validation
It's should look like the Figma
https://www.figma.com/design/pu1vZPqNIM7BePd6W8APA5/Node.js?node-id=695-14399&t=aqPF3hoDGhAb29rs-1
Related Issues
#7037 (comment)
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.