feat: official vs community and instructions for downloads page #7365

ovflowd · 2024-12-28T14:58:24Z

This PR, in a practical term, adds the differentiation between Official and Community installation methods and documentation for adding an Installation Method.

This is a significant guideline and content change hence, it requires approval from @nodejs/releasers @nodejs/package-maintenance @nodejs/nodejs-website

vercel · 2024-12-28T14:58:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jan 7, 2025 3:33am

github-actions · 2024-12-28T14:59:11Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 87	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

github-actions · 2024-12-28T15:00:16Z

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	87.6% (735/839)	74.14% (238/321)	86.58% (142/164)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
182	0 💤	0 ❌	0 🔥	6.345s ⏱️

ovflowd · 2024-12-28T15:10:28Z

cc @cinderblock @ImBIOS. Feel free to open new PRs following the guidelines for adding Proto and Winget as installation methods.

ovflowd · 2024-12-28T15:13:37Z

cc @MattIPv4 and @ljharb as y'all were interested on this!

apps/site/pages/en/about/previous-releases.mdx

COLLABORATOR_GUIDE.md

apps/site/pages/en/about/previous-releases.mdx

apps/site/components/__design__/platform-logos.stories.tsx

COLLABORATOR_GUIDE.md

Signed-off-by: Claudio W <cwunder@gnome.org>

ovflowd · 2025-01-06T16:22:10Z

@ljharb another final review from your side? :D

COLLABORATOR_GUIDE.md

AugustinMauroy

SGTM

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio W <cwunder@gnome.org>

ovflowd requested a review from a team as a code owner December 28, 2024 14:58

ovflowd requested a review from a team December 28, 2024 14:58

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

vercel bot deployed to Preview December 28, 2024 14:58 View deployment

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

ovflowd deployed to Storybook December 28, 2024 14:58 — with GitHub Actions View deployment

vercel bot deployed to Preview December 28, 2024 15:02 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

ovflowd deployed to Storybook December 28, 2024 15:05 — with GitHub Actions View deployment

vercel bot deployed to Preview December 28, 2024 15:05 View deployment

ovflowd mentioned this pull request Dec 28, 2024

Make "fnm" an official installation method for Node.js on Windows Schniz/fnm#1357

Open

ovflowd commented Dec 28, 2024

View reviewed changes

apps/site/pages/en/about/previous-releases.mdx Show resolved Hide resolved

ovflowd commented Dec 28, 2024

View reviewed changes

COLLABORATOR_GUIDE.md Show resolved Hide resolved

MattIPv4 reviewed Dec 28, 2024

View reviewed changes

apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved

apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved

apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview December 28, 2024 18:05 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024

ovflowd deployed to Storybook December 28, 2024 18:08 — with GitHub Actions View deployment

ljharb reviewed Dec 28, 2024

View reviewed changes

apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved

targos reviewed Dec 28, 2024

View reviewed changes

apps/site/pages/en/about/previous-releases.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview December 28, 2024 18:21 View deployment

AugustinMauroy reviewed Dec 28, 2024

View reviewed changes

apps/site/components/__design__/platform-logos.stories.tsx Show resolved Hide resolved

mikeesto reviewed Dec 29, 2024

View reviewed changes

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

ovflowd mentioned this pull request Dec 29, 2024

docs: add Devbox as commumity download option #7370

Merged

5 tasks

Update previous-releases.mdx

8c25782

Signed-off-by: Claudio W <cwunder@gnome.org>

vercel bot deployed to Preview January 6, 2025 16:16 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 6, 2025

ovflowd deployed to Storybook January 6, 2025 16:17 — with GitHub Actions View deployment

ljharb approved these changes Jan 6, 2025

View reviewed changes

canerakdas reviewed Jan 6, 2025

View reviewed changes

AugustinMauroy approved these changes Jan 6, 2025

View reviewed changes

MattIPv4 approved these changes Jan 6, 2025

View reviewed changes

bmuenzenmeyer and others added 2 commits January 6, 2025 20:14

Update COLLABORATOR_GUIDE.md

ed1d959

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

Update COLLABORATOR_GUIDE.md

a603c6e

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

vercel bot deployed to Preview January 7, 2025 02:16 View deployment

bmuenzenmeyer and others added 2 commits January 6, 2025 20:17

Update COLLABORATOR_GUIDE.md

6a27700

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

Update COLLABORATOR_GUIDE.md

71b0e37

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>

vercel bot deployed to Preview January 7, 2025 02:19 View deployment

bmuenzenmeyer approved these changes Jan 7, 2025

View reviewed changes

Apply suggestions from code review

035e758

Co-authored-by: Caner Akdas <canerakdas@gmail.com> Signed-off-by: Claudio W <cwunder@gnome.org>

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2025

ovflowd enabled auto-merge January 7, 2025 03:33

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 7, 2025

ovflowd deployed to Storybook January 7, 2025 03:33 — with GitHub Actions View deployment

vercel bot deployed to Preview January 7, 2025 03:33 View deployment

ovflowd added this pull request to the merge queue Jan 7, 2025

Merged via the queue into main with commit b417a64 Jan 7, 2025
16 checks passed

ovflowd deleted the feat/official-community-docs branch January 7, 2025 03:43

wesleytodd mentioned this pull request Jan 8, 2025

Wishlist on managing package manager versions in a Node.js application nodejs/package-maintenance#609

Open

This was referenced Jan 31, 2025

Show n-install for installing n on Node.js downloads page? mklement0/n-install#60

Closed

Show n-install for installing n on Node.js downloads page tj/n#829

Closed

Uh oh!

feat: official vs community and instructions for downloads page #7365

feat: official vs community and instructions for downloads page #7365

Uh oh!

Conversation

ovflowd commented Dec 28, 2024

Uh oh!

vercel bot commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Coverage Report

Unit Test Report

Uh oh!

ovflowd commented Dec 28, 2024

Uh oh!

ovflowd commented Dec 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd commented Jan 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vercel bot commented Dec 28, 2024 •

edited

Loading

github-actions bot commented Dec 28, 2024 •

edited

Loading

github-actions bot commented Dec 28, 2024 •

edited

Loading