Skip to content

Conversation

@flakey5
Copy link
Member

@flakey5 flakey5 commented Mar 11, 2025

Blog post for announcing the R2 migration!

Ideally this can be merged after #7544 so we can use it in the diagrams instead of adding more images.

@vercel
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 5, 2025 7:10pm

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 75 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 87 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.74% (500/590) 76.03% (165/217) 87.09% (108/124)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 4.732s ⏱️
@nodejs/website 157 0 💤 0 ❌ 0 🔥 6.616s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Mar 12, 2025

We won't be able to support Mermaid rendering soon, unfortunately. The package mermaid-isomorphic does some funky things.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flakey5 I think we can proceed with this as it is. Mermaid support will probably take a long while.

Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@flakey5
Copy link
Member Author

flakey5 commented Mar 28, 2025

cc @nodejs/build

@flakey5 flakey5 marked this pull request as ready for review March 28, 2025 20:15
@flakey5 flakey5 requested review from a team as code owners March 28, 2025 20:15
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
@ovflowd
Copy link
Member

ovflowd commented Apr 3, 2025

@flakey5 we're good to go :)

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

flakey5 added 2 commits April 3, 2025 08:42
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Signed-off-by: flakey5 <73616808+flakey5@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could have a SVG version instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry missed this 🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? Fwiw the precedent has been just images, but either work

@ovflowd ovflowd merged commit 9884c3e into main Apr 5, 2025
5 checks passed
@ovflowd ovflowd deleted the flakey5/20241228/r2-blog-post branch April 5, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants