Skip to content

fix: convert incorrect breadcrumb links to opaque spans #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 3 commits into from
May 9, 2025
Merged

fix: convert incorrect breadcrumb links to opaque spans #7626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fbff2c
fix: convert incorrect breadcrumb links to opaque spans
dario-piotrowicz Apr 6, 2025
0e3276b
add linkless story
dario-piotrowicz Apr 7, 2025
82a4e57
make sure last item is always displayed as active
dario-piotrowicz Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/ui-components/Common/Breadcrumbs/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,25 @@ export const Default: Story = {
},
};

export const Linkless: Story = {
args: {
links: [
{
label: 'Learn',
href: '',
},
{
label: 'Getting Started',
href: '',
},
{
label: 'Introduction to Node.js',
href: '',
},
],
},
};

export const Truncate: Story = {
args: {
links: [
Expand Down
14 changes: 11 additions & 3 deletions packages/ui-components/Common/Breadcrumbs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,17 @@ const Breadcrumbs: FC<BreadcrumbsProps> = ({
hideSeparator={isLastItem}
position={position + +!hideHome}
>
<BreadcrumbLink as={as} href={link.href} active={isLastItem}>
{link.label}
</BreadcrumbLink>
{link.href || isLastItem ? (
<BreadcrumbLink
as={as}
href={link.href || undefined}
active={isLastItem}
>
{link.label}
</BreadcrumbLink>
) : (
<span className="opacity-70">{link.label}</span>
)}
</BreadcrumbItem>
);
}),
Expand Down
Loading