fix(learn): improve 'Understanding process.nextTick()' doc page example code. #7679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kekekuli
changed the title
avivkeller
reviewed
Apr 24, 2025
| ``` | ||
|
|
||
| The exact output may differ from run to run. | ||
| The exact output may differ from run to run. [setImmediate vs setTimeout](https://nodejs.org/en/learn/asynchronous-work/event-loop-timers-and-nexttick#setimmediate-vs-settimeout) explain the reason. |
Member
There was a problem hiding this comment.
Honestly, at this point, maybe replace the whole section with a summary of why the order is the way it is, and then link to the more detailed explanation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7679 +/- ##
==========================================
- Coverage 74.63% 74.61% -0.03%
==========================================
Files 96 96
Lines 7689 7689
Branches 192 192
==========================================
- Hits 5739 5737 -2
- Misses 1948 1950 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'Understanding process.nextTick()' doc have one messy example code and example ouput caused by setImmediate() vs setTimeout(). Example code in that doc saying that setImmediate will always have higher order been executed, which may confused for the readers
Validation
The example code has been reviewed to correctly reflect the behavior of the executed order for both setImmediate and setTimeout.
Reviewers should verify that the updated explanation is both technically correct and clearly communicates. No functional or visual changes—only documentation improvements.
Related Issues
Fixes nodejs/node#58000
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.