Skip to content

Conversation

@jpbnetley
Copy link
Contributor

@jpbnetley jpbnetley commented Apr 24, 2025

Description

Update the nvm version since a new release was made for nvm:

Validation

Related Issues

#7683

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

closes #7683

@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 24, 2025 4:21pm

@github-actions

This comment has been minimized.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jpbnetley jpbnetley marked this pull request as ready for review April 24, 2025 16:22
@jpbnetley jpbnetley requested a review from a team as a code owner April 24, 2025 16:22
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (3531779) to head (c8f3b47).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7684      +/-   ##
==========================================
- Coverage   74.81%   74.80%   -0.02%     
==========================================
  Files          98       98              
  Lines        7842     7842              
  Branches      197      197              
==========================================
- Hits         5867     5866       -1     
- Misses       1973     1974       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@araujogui
Copy link
Member

@nodejs/nodejs-website Fast-tracking this

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Apr 25, 2025
@avivkeller avivkeller enabled auto-merge April 25, 2025 13:52
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 25, 2025
@avivkeller avivkeller added this pull request to the merge queue Apr 25, 2025
Merged via the queue into nodejs:main with commit e19099e Apr 25, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVM version got updated, so the npm docs is outdated a bit since it references the old version

8 participants