chore(next): remove vercel.json and extra log, update fonts

[ovflowd]

This PR removes a console.log; removes vercel.json and switches to local fonts, because, yes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	May 3, 2025 0:50am

[Copilot]

Pull Request Overview

This PR removes a no longer needed console.log statement from the release data generator and switches font loading from external Google fonts to local assets.

• Removed debug logging in releaseData.mjs
• Updated font configurations in next.fonts.ts to use local fonts instead of remote fonts

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File	Description
apps/site/next.fonts.ts	Updated to load fonts from local assets instead of Google fonts
apps/site/next-data/generators/releaseData.mjs	Removed console.log debugging output

Files not reviewed (1)

• apps/site/vercel.json: Language not supported

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (2f9f1b2) to head (35dddbf).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7718   +/-   ##
=======================================
  Coverage   74.82%   74.83%           
=======================================
  Files          98       98           
  Lines        7878     7876    -2     
  Branches      199      199           
=======================================
- Hits         5895     5894    -1     
+ Misses       1982     1981    -1     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ovflowd]

Vercel build will work once this gets merged (gotta remove the file overrides)

[avivkeller]

Per #7718 (comment)

We should not land this unless we can confirm, and prove, that the fonts we are using are from trusted sources.

[ovflowd]

Per #7718 (comment)

We should not land this unless we can confirm, and prove, that the fonts we are using are from trusted sources.

Why them being on a GitHub repository doesn't mean it came from an official source? All these fonts have very permissive licenses, so you can pretty much obtain them from anywhere. https://fonts.google.com/specimen/Open+Sans/license

[ovflowd]

I went ahead and got fonts from Google Fonts through this Web Helper: https://gwfh.mranftl.com/fonts

Stale Review

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟠 83	🔗
/en/download	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[avivkeller]

Why them being on a GitHub repository doesn't mean it came from an official source? All these fonts have very permissive licenses, so you can pretty much obtain them from anywhere. https://fonts.google.com/specimen/Open+Sans/license

There's nothing wrong with use a GitHub repository. "Official" wasn't the right terminology. I meant "trusted". When you said you got the fronts from "some random GitHub repositories", it didn't seem like I could trust that the fonts used are the best / safest (although, what's unsafe about a font?) available.

Now that you've linked the source of the fonts, I'm happy to approve this PR knowing they are coming from a trusted source :-).

[ovflowd]

Why them being on a GitHub repository doesn't mean it came from an official source? All these fonts have very permissive licenses, so you can pretty much obtain them from anywhere. https://fonts.google.com/specimen/Open+Sans/license

There's nothing wrong with use a GitHub repository. "Official" wasn't the right terminology. I meant "trusted". When you said you got the fronts from "some random GitHub repositories", it didn't seem like I could trust that the fonts used are the best / safest (although, what's unsafe about a font?) available.

Now that you've linked the source of the fonts, I'm happy to approve this PR knowing they are coming from a trusted source :-).

I find the logic of blocking the PR first asking later (and possibly assuming that I wouldn't be auditing/reviewing the files/sources) a bit shocking. I'd hoped y'all trusted me more.

[avivkeller]

I find the logic of blocking the PR first asking later (and possibly assuming that I wouldn't be auditing/reviewing the files/sources) a bit shocking. I'd hoped y'all trusted me more.

I'm not saying I don’t trust you. The block was simply a way of expressing that I don’t approve the landing until certain conditions (like XYZ) are met.

Also, I didn’t block first and ask questions later—I had already requested the sources to be linked, and the response I received led me to make the decision to block.

[ovflowd]

I find the logic of blocking the PR first asking later (and possibly assuming that I wouldn't be auditing/reviewing the files/sources) a bit shocking. I'd hoped y'all trusted me more.

I'm not saying I don’t trust you. The block was simply a way of expressing that I don’t approve the landing until certain conditions (like XYZ) are met.

Also, I didn’t block first and ask questions later—I had already requested the sources to be linked, and the response I received led me to make the decision to block.

I disagree with that interpretation of the events; I was clearly (or at least I thought so) joking and trying to make a lighthearted fun out of it; Apologies if that was not appropriate or direct enough.

It is your right to block a PR, but the insinuation of the sources... That's what made me uncomfortable.

I hope the PR is in a mergeable position for you now.

[avivkeller]

It's in a mergeable position now. I didn't mean to make you uncomfortable, I just wanted to be safe. We both have good intentions at heart :)

[ovflowd]

It's in a mergeable position now. I didn't mean to make you uncomfortable, I just wanted to be safe. We both have good intentions at heart :)

I know, but I wanted you to understand my position, a tad over dramatic, yes.

[ovflowd]

Requesting fast-track, react with a 👍 if you approve.