-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(pnpm): use installed dependencies for pre-commit hook #7741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the pre-commit hook to use installed dependencies via pnpm instead of fetching them remotely with dlx.
- Updated linting command from "pnpm dlx lint-staged" to "pnpm exec lint-staged".
- Replaced the TypeScript build command with "pnpm check-types" to align with using installed dependencies.
Comments suppressed due to low confidence (2)
.husky/pre-commit:2
- Switching from 'pnpm dlx lint-staged' to 'pnpm exec lint-staged' is a good move towards using installed dependencies. Please ensure that lint-staged is properly listed as a dependency to avoid runtime errors.
pnpm exec lint-staged
.husky/pre-commit:5
- Replacing the TypeScript 'dlx tsc --build apps/site' command with 'pnpm check-types' simplifies dependency management. Verify that 'pnpm check-types' provides equivalent type checking coverage for your project.
pnpm check-types
Co-authored-by: Matt Cowley <me@mattcowley.co.uk> Signed-off-by: Aviv Keller <me@aviv.sh>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7741 +/- ##
==========================================
+ Coverage 74.83% 74.87% +0.03%
==========================================
Files 98 98
Lines 7891 7895 +4
Branches 200 200
==========================================
+ Hits 5905 5911 +6
+ Misses 1985 1983 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
|
Lighthouse Results
|
Per #7738