Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented May 16, 2025

This PR fixes a few bugs in, and hardens, the Crowdin workflow.

@vercel
Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 19, 2025 2:48pm

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.05%. Comparing base (fd87584) to head (ab2e13a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7755      +/-   ##
==========================================
+ Coverage   74.85%   75.05%   +0.19%     
==========================================
  Files          98       98              
  Lines        7895     7914      +19     
  Branches      200      196       -4     
==========================================
+ Hits         5910     5940      +30     
+ Misses       1984     1973      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chore: sync translations from crowdin

Signed-off-by: nodejs-crowdin <nodejs-crowdin@users.noreply.github.com>
Co-authored-by: nodejs-crowdin <nodejs-crowdin@users.noreply.github.com>
@avivkeller avivkeller marked this pull request as ready for review May 16, 2025 21:58
Copilot AI review requested due to automatic review settings May 16, 2025 21:58
@avivkeller avivkeller requested review from a team as code owners May 16, 2025 21:58
@avivkeller
Copy link
Member Author

@github-actions

This comment was marked as resolved.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR focuses on fixing bugs and improving the Crowdin workflow by updating translation keys in locale files, enhancing MDX content for the About pages, and refining the GitHub translations sync workflow.

  • Updated translation JSON files (zh-tw and uk) with new keys and revised content.
  • Modified MDX pages to improve layout, accessibility, and resource information.
  • Refactored the translations sync GitHub workflow for better branch naming, commit handling, and overall operational reliability.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/i18n/locales/zh-tw.json Added new translation keys and restructured release information.
packages/i18n/locales/uk.json Synchronized new translation keys and updated copy for release details.
apps/site/pages/zh-tw/about/branding.mdx Upgraded layout structure, enhanced image references, and credited contributor.
apps/site/pages/uk/about/previous-releases.mdx Revised content to clarify official vs. community installation methods.
apps/site/pages/uk/about/index.mdx Introduced additional sections for official Node.js resources and communication channels.
.github/workflows/translations-sync.yml Refined workflow job names, branch handling, and commit process for translation updates.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there are changes on translation file ?

@avivkeller
Copy link
Member Author

I combined this with the weekly translate run do demo the new, working script.

@avivkeller
Copy link
Member Author

@nodejs/web-infra can I get some approvals on your end 😃? Thanks!

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @bmuenzenmeyer LGTM

Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, this seems like a ton of bikeshedding atop the substantive change of using lint-staged, which is doing more than it needs to (linting, in addition to formatting), with the loss of many code comments essential for the running of the action.

The force push is concerning to me too.

@avivkeller
Copy link
Member Author

Sorry for all the bikeshedding–I shouldn've kept this on topic.

Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller requested a review from bmuenzenmeyer May 19, 2025 14:47
@avivkeller
Copy link
Member Author

I've changed the lint-staged to just use ESLint and prettier. While they'll run over files that haven't changed, the cache should prevent them from actually checking said files.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue May 21, 2025
Merged via the queue into main with commit 3d50b07 May 21, 2025
18 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the fix/crowdin-workflow branch May 21, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants