Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented May 21, 2025

Unfortunately, because there was response in #7487 to multiple requests over the past few weeks, this PR removes the Windows instructions from fnm.

CC @Schniz

Copilot AI review requested due to automatic review settings May 21, 2025 17:16
@avivkeller avivkeller requested a review from a team as a code owner May 21, 2025 17:16
@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 21, 2025 9:01pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reclassifies the installation method of fnm by removing it from the "Recommended" list and placing it under "Community."

  • Removed the "recommended": true flag from the fnm configuration in constants.json.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (663fad9) to head (e7fe0d0).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7769      +/-   ##
==========================================
+ Coverage   75.09%   75.36%   +0.26%     
==========================================
  Files          98       96       -2     
  Lines        7914     7858      -56     
  Branches      196      192       -4     
==========================================
- Hits         5943     5922      -21     
+ Misses       1970     1935      -35     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MattIPv4
Copy link
Member

MattIPv4 commented May 21, 2025

👀 Could I suggest that we just remove the broken Windows option, instead of downgrading fnm across all platforms? I see no reason for us to keep the Windows instructions, recommended or not, when they're broken, but the macOS/Linux instructions seem perfectly fine to continue recommending?

@avivkeller avivkeller changed the title chore(download): stop recommending fnm chore(download): remove windows instructions from fnm May 21, 2025
@avivkeller avivkeller force-pushed the chore/stop-recommending-fnm branch from c8b6250 to e7fe0d0 Compare May 21, 2025 21:00
@avivkeller
Copy link
Member Author

Done. No snippets need to be changed as the Windows version uses the same snippet (with an if condition, which I think it's fine to keep for if/when we re-add fnm).

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller linked an issue May 23, 2025 that may be closed by this pull request
@avivkeller avivkeller added this pull request to the merge queue May 23, 2025
Merged via the queue into main with commit 634567e May 23, 2025
16 of 17 checks passed
@avivkeller avivkeller deleted the chore/stop-recommending-fnm branch May 23, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fnm download snippet fails on Windows

5 participants