Skip to content

Conversation

@joyeecheung
Copy link
Member

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings May 21, 2025 22:22
@joyeecheung joyeecheung requested a review from a team as a code owner May 21, 2025 22:22
@vercel
Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 23, 2025 5:02pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Add a trip report for the Node.js Collaboration Summit held in Paris, covering key sessions and outcomes.

  • Introduces a new blog post with metadata (date, title, author) under the events category.
  • Summarizes sessions on CI security, experimental features, mentorship, collaborator experience, and more.
Comments suppressed due to low confidence (1)

apps/site/pages/en/blog/events/collab-summit-2025-paris.md:96

  • Correct spelling: change 'rewritting' to 'rewriting'.
…without rewritting the AST in a third-party tool.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (39e3ae1) to head (f37144b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7772      +/-   ##
==========================================
+ Coverage   75.31%   75.34%   +0.02%     
==========================================
  Files          96       96              
  Lines        7856     7861       +5     
  Branches      192      192              
==========================================
+ Hits         5917     5923       +6     
+ Misses       1938     1937       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a lot of fun! Maybe I'll be able to stop by the next one 🤞!

@joyeecheung
Copy link
Member Author

It seems the Playwright tests keep failing after I added another author. Trying to remove it. @overflowd

@avivkeller
Copy link
Member

Can you rebase?

joyeecheung and others added 7 commits May 23, 2025 18:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@avivkeller
Copy link
Member

Thank you! That resolved the issue.

We added playwright tests yesterday-ish, so that's why it failed previously

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 23, 2025
@ovflowd ovflowd enabled auto-merge May 23, 2025 22:56
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd added this pull request to the merge queue May 23, 2025
Merged via the queue into nodejs:main with commit 6262210 May 23, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants