-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(learn): correct mocking example #7779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Colin Ihrig <cjihrig@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an incorrect mock API usage in the example provided in mocking.md.
- Corrects the method chaining on the mock function in the code snippet.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7779 +/- ##
==========================================
+ Coverage 75.34% 75.35% +0.01%
==========================================
Files 96 96
Lines 7861 7861
Branches 192 192
==========================================
+ Hits 5923 5924 +1
+ Misses 1937 1936 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Lighthouse Results
|
Description
This example appears to be incorrect.
Validation
Related Issues
Fixes: nodejs/node#58462
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.