Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 26, 2025

Description

This example appears to be incorrect.

Validation

Related Issues

Fixes: nodejs/node#58462

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Colin Ihrig <cjihrig@gmail.com>
Copilot AI review requested due to automatic review settings May 26, 2025 16:16
@cjihrig cjihrig requested a review from a team as a code owner May 26, 2025 16:16
@vercel
Copy link

vercel bot commented May 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 26, 2025 4:17pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an incorrect mock API usage in the example provided in mocking.md.

  • Corrects the method chaining on the mock function in the code snippet.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.35%. Comparing base (d261c9f) to head (987cc53).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7779      +/-   ##
==========================================
+ Coverage   75.34%   75.35%   +0.01%     
==========================================
  Files          96       96              
  Lines        7861     7861              
  Branches      192      192              
==========================================
+ Hits         5923     5924       +1     
+ Misses       1937     1936       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller changed the title Update mocking.md fix(learn): correct mocking example May 26, 2025
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label May 26, 2025
@avivkeller avivkeller added the fast-track Fast Tracking PRs label May 26, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 77 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller enabled auto-merge May 26, 2025 17:13
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label May 26, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label May 26, 2025
@avivkeller avivkeller added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit d122e58 May 26, 2025
30 checks passed
@avivkeller avivkeller deleted the cjihrig-patch-1 branch May 26, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot call mockImplementationOnce on empty function

6 participants