Skip to content

Conversation

@Shubham2552
Copy link
Contributor

@Shubham2552 Shubham2552 commented May 28, 2025

Description

This PR is to bring the JSConf badge back which was initially shown on homepage, and was changed and replaced with Next-10 survey badge link to the issue #7730, and a link to the pr where it was modified - #7726, the only change done is replace the changes back with original badge, code from this above PR is referred for that.

Validation

Changes are visible on hompage. Screenshot 2025-05-28 195100

Related Issues

#7730

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Shubham2552 Shubham2552 requested a review from a team as a code owner May 28, 2025 14:24
@vercel
Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 29, 2025 11:00pm

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be merged until June 1

@AugustinMauroy
Copy link
Member

cc @kyliewd

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (d122e58) to head (b0a23c3).
Report is 15 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7784      +/-   ##
==========================================
- Coverage   75.35%   75.32%   -0.04%     
==========================================
  Files          96       96              
  Lines        7861     7862       +1     
  Branches      192      192              
==========================================
- Hits         5924     5922       -2     
- Misses       1936     1939       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Tierney Cyren <accounts@bnb.im>
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller changed the title add back JSConf Badge chore(jsconf): re-add badge May 29, 2025
@avivkeller avivkeller enabled auto-merge June 1, 2025 02:04
@avivkeller avivkeller added github_actions:pull-request Trigger Pull Request Checks and removed on hold labels Jun 1, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue Jun 1, 2025
Merged via the queue into nodejs:main with commit a6881bd Jun 1, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reminder to add JSConf to the website

8 participants