-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(meta): downgrade pnpm to 10.8.1 #7822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR downgrades the project’s pnpm version to 10.8.1 to work around a bug introduced in pnpm 10.9.0.
- Update
packageManagerfield to use pnpm@10.8.1 - Align
devEngines.packageManager.versionwith pnpm@10.8.1
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7822 +/- ##
=======================================
Coverage 75.48% 75.48%
=======================================
Files 101 101
Lines 8309 8309
Branches 218 218
=======================================
Hits 6272 6272
Misses 2035 2035
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting fast track
|
Quite the serious bug, ngl. |
|
Lighthouse Results
|
5b5a50b to
cbf7d70
Compare
|
Sorry to snoop, did this work for you guys? (I think so looking at the dependabot PRs) |
|
It did, take a look at all the currently open Dependabot PRs -- they have correct diffs now instead of +/- 2k diffs for every dep in the lockfile. |
|
Thanks for confirming! |
Description
Dependabot is currently updating all dependencies in the lockfile in each PR it opens: e52dea5
This appears to be due to a bug in pnpm since 10.9.0, so this downgrades us to the last pnpm release prior to that.
Validation
Managing dependencies continues to work. We'll need to merge and then ask Dependabot to update its PRs to fully validate if this works.
Related Issues
pnpm/pnpm#9519
(As an aside, dependabot/dependabot-core#11246 + https://docs.github.com/en/code-security/dependabot/ecosystems-supported-by-dependabot/supported-ecosystems-and-repositories#supported-ecosystems-and-repositories does suggest that Dependabot doesn't officially support pnpm 10 at all)
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.