chore(next): remove icons from optimizedPackageImports

[avivkeller]

Next.js already optimizes this import internally:
https://github.com/vercel/next.js/blob/12e888126ccf968193e7570a68db1bc35f90d52d/packages/next/src/server/config.ts#L715-L717

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Jun 2, 2025 0:20am

[Copilot]

Pull Request Overview

This PR removes the '@heroicons/react' package from the optimizedPackageImports array as Next.js already optimizes it internally.

• Removed '@heroicons/react' from the optimizedPackageImports
• Updated apps/site/next.config.mjs accordingly

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (c11af00) to head (9670246).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7825      +/-   ##
==========================================
- Coverage   75.48%   75.46%   -0.03%     
==========================================
  Files         101      101              
  Lines        8309     8309              
  Branches      218      218              
==========================================
- Hits         6272     6270       -2     
- Misses       2035     2037       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MattIPv4]

Thoughts on using smth like https://github.com/hashicorp/nextjs-bundle-analysis so that we'd have empirical data (easily accessed, I realise we can run local analysis w/ foam tree) to confirm a change like this hasn't changed the bundle drastically?

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 81	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟠 82	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟠 83	🔗
/en/download	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[ovflowd]

Thoughts on using smth like https://github.com/hashicorp/nextjs-bundle-analysis so that we'd have empirical data (easily accessed, I realise we can run local analysis w/ foam tree) to confirm a change like this hasn't changed the bundle drastically?

We had that in the past, but needs to be added within the next.js config file... And it slows down builds enormously...