Skip to content

feat(codecov): bundle analyzer #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
avivkeller wants to merge 8 commits into from
Closed

feat(codecov): bundle analyzer #7829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1cc6940
feat(codecov): bundle analyzer
avivkeller Jun 2, 2025
6c74881
fixup!
avivkeller Jun 2, 2025
634bd49
fixup!
avivkeller Jun 2, 2025
06731c7
fixup!
avivkeller Jun 2, 2025
1b5aadf
fixup!
avivkeller Jun 2, 2025
69961c8
fixup!
avivkeller Jun 2, 2025
13815b4
fixup!
avivkeller Jun 2, 2025
8d8b4d0
fixup!
avivkeller Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ jobs:
NODE_OPTIONS: '--max_old_space_size=4096'
# Used for API requests that require GitHub API scopes
NEXT_GITHUB_API_KEY: ${{ secrets.GITHUB_TOKEN }}
# Codecov
NEXT_PUBLIC_ANALYZE: ${{ matrix.os == 'ubuntu-latest' && github.event_name != 'merge_group' }}

- name: Build Next.js (Static All Locales)
# We only run full static builds within Pull Requests. This step is also used to export
Expand Down
15 changes: 15 additions & 0 deletions apps/site/next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
'use strict';
import { codecovNextJSWebpackPlugin } from '@codecov/nextjs-webpack-plugin';
import createNextIntlPlugin from 'next-intl/plugin';

import { BASE_PATH, ENABLE_STATIC_EXPORT } from './next.constants.mjs';
Expand Down Expand Up @@ -96,6 +97,20 @@ const nextConfig = {
'shiki',
],
},
webpack: (config, options) => {
Copy link
Member

@ovflowd ovflowd Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work even with TurboPack enabled? We are by default building on CI with TurboPack... So I imagine this wouldn't work?

Copy link
Member Author

@avivkeller avivkeller Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nodejs/nodejs.org/actions/runs/15397287888/job/43321170486#step:10:50

Copy link
Member

@ovflowd ovflowd Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, apparently you passing the webpack config flag is disabling turbopack :/

Copy link
Member

@ovflowd ovflowd Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh https://github.com/nodejs/nodejs.org/blob/main/apps/site/package.json#L6 did someone remove the --turbo flag?

Copy link
Member

@MattIPv4 MattIPv4 Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removed as part of the Cloudflare adapter PR

Copy link
Member Author

@avivkeller avivkeller Jun 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that should be re enabled? I'll adjust this PR accordingly if that flag is added back

Copy link
Member

@ovflowd ovflowd Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7830

if (process.env.ANALYZE) {
config.plugins.push(
codecovNextJSWebpackPlugin({
enableBundleAnalysis: true,
bundleName: '@node-core/website',
webpack: options.webpack,
telemetry: false,
})
);
}

return config;
},
};

const withNextIntl = createNextIntlPlugin('./i18n.tsx');
Expand Down
1 change: 1 addition & 0 deletions apps/site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"cloudflare:deploy": "wrangler deploy"
},
"dependencies": {
"@codecov/nextjs-webpack-plugin": "^1.9.1",
"@heroicons/react": "~2.2.0",
"@mdx-js/mdx": "^3.1.0",
"@node-core/rehype-shiki": "workspace:*",
Expand Down
Loading
Loading