-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: broken script in example package.json #7833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The script for run is supposed to eventually run `node app.js --watch` by running `node --run start` with the `--watch` parameter - but the name of the script was missing resulting in a syntax error. Signed-off-by: Dor Kleiman <configurator@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! Thanks for your contribution 🥳
|
LGMT ! 🎉 Congrats on your first contribution |
|
@configurator is this intentionally still a draft? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7833 +/- ##
==========================================
- Coverage 75.48% 75.46% -0.03%
==========================================
Files 101 101
Lines 8309 8309
Branches 218 218
==========================================
- Hits 6272 6270 -2
- Misses 2035 2037 +2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Only because I haven't managed to run the format lint and test yet - I've never contributed to this repo before so I'm not sure if this is strictly required for a change of this magnitude, but I'm erring on the side of caution. I've run into installation errors when trying to install the project and haven't had the time to resolve them so I've opened a draft until I can run them later today. |
|
No worries, the CI ran them and they passed, so you are good to go if this is ready for review. |
|
Lighthouse Results
|
Description
The script for run is supposed to eventually run
node app.js --watchby runningnode --run startwith the--watchparameter - but the name of the script was missing resulting in a syntax error.Validation
It's a textual change; I've gone ahead and copied the example package.json to an actual file anyway to see that after the fix the script runs successfully.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.