Skip to content

Conversation

@configurator
Copy link
Contributor

@configurator configurator commented Jun 4, 2025

Description

The script for run is supposed to eventually run node app.js --watch by running node --run start with the --watch parameter - but the name of the script was missing resulting in a syntax error.

Validation

It's a textual change; I've gone ahead and copied the example package.json to an actual file anyway to see that after the fix the script runs successfully.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

The script for run is supposed to eventually run `node app.js --watch` by running `node --run start` with the `--watch` parameter - but the name of the script was missing resulting in a syntax error.

Signed-off-by: Dor Kleiman <configurator@gmail.com>
@vercel
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 4, 2025 10:29am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! Thanks for your contribution 🥳

@aymen94
Copy link
Member

aymen94 commented Jun 4, 2025

LGMT ! 🎉 Congrats on your first contribution

@avivkeller
Copy link
Member

@configurator is this intentionally still a draft?

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (82142e7) to head (5d7de6c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7833      +/-   ##
==========================================
- Coverage   75.48%   75.46%   -0.03%     
==========================================
  Files         101      101              
  Lines        8309     8309              
  Branches      218      218              
==========================================
- Hits         6272     6270       -2     
- Misses       2035     2037       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@configurator
Copy link
Contributor Author

@configurator is this intentionally still a draft?

Only because I haven't managed to run the format lint and test yet - I've never contributed to this repo before so I'm not sure if this is strictly required for a change of this magnitude, but I'm erring on the side of caution.

I've run into installation errors when trying to install the project and haven't had the time to resolve them so I've opened a draft until I can run them later today.

@avivkeller
Copy link
Member

No worries, the CI ran them and they passed, so you are good to go if this is ready for review.

@avivkeller avivkeller marked this pull request as ready for review June 4, 2025 19:08
@avivkeller avivkeller requested a review from a team as a code owner June 4, 2025 19:08
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller added this pull request to the merge queue Jun 6, 2025
Merged via the queue into nodejs:main with commit 1171936 Jun 6, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants