Skip to content

Conversation

@avivkeller
Copy link
Member

This file is (hopefully) the first thing a contributor is going to read, so we should use the actual syntax that they will need to know when contributing.

I'm fast tracking this, so merge when ready

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings June 4, 2025 20:17
@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jun 4, 2025
@avivkeller avivkeller requested a review from a team as a code owner June 4, 2025 20:17
@vercel
Copy link

vercel bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 4, 2025 8:17pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CONTRIBUTING.md file to use backticks in example code blocks instead of triple single quotes, aligning the examples with the actual syntax used by contributors.

  • Updated markdown delimiters for code blocks
  • Ensured consistency in example language markers for CommonJS and ES Modules
Comments suppressed due to low confidence (1)

CONTRIBUTING.md:378

  • The use of four backticks for the markdown code block is unusual; please ensure that this convention is clearly documented in CONTRIBUTING.md so that contributors understand it is intentional.
+````md

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (c757502) to head (2421ead).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
- Coverage   75.48%   75.46%   -0.03%     
==========================================
  Files         101      101              
  Lines        8309     8309              
  Branches      218      218              
==========================================
- Hits         6272     6270       -2     
- Misses       2035     2037       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 2054bcc Jun 4, 2025
19 checks passed
@avivkeller avivkeller deleted the fast-track/contributing-use-backtick branch June 4, 2025 21:11
@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

I'm fast tracking this, so merge when ready

You mean you're requesting fast-tracking right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants