Skip to content

Conversation

@AugustinMauroy
Copy link
Member

Description

IMO previous order of the navigation doesn't make sense.

The logic behind this is that

  • About comes first because it is the theme of the section
  • Node versions because this impacts many users
  • Security reports are important for the project
  • Then governance to understand how the project works
  • And finally branding, which is just there for some users

Related Issues

No related issue.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings June 6, 2025 21:15
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner June 6, 2025 21:15
@vercel
Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 6, 2025 9:15pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders the sub-navigation items under the About section to follow the new logical sequence.

  • Removes branding and governance from above previousReleases
  • Inserts securityReporting, then governance, then branding after previousReleases
Comments suppressed due to low confidence (2)

apps/site/navigation.json:112

  • Consider adding or updating unit tests to validate this new navigation order to prevent regressions if items are modified in the future.
"securityReporting": {

apps/site/navigation.json:102

  • [nitpick] To improve clarity for future maintainers, consider extracting the About sub-navigation order into a shared constant or adding a comment that explains the rationale behind this specific ordering.
"link": "/about",

@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.48%. Comparing base (ed840c2) to head (7661560).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7841      +/-   ##
==========================================
+ Coverage   75.46%   75.48%   +0.02%     
==========================================
  Files         101      101              
  Lines        8305     8305              
  Branches      218      218              
==========================================
+ Hits         6267     6269       +2     
+ Misses       2036     2034       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jun 6, 2025
@avivkeller
Copy link
Member

@nodejs/nodejs-website Seeing as this is a pretty straight forward change, I'm requesting fast-track Fast Tracking PRs

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 82 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd added this pull request to the merge queue Jun 7, 2025
Merged via the queue into main with commit ab61d45 Jun 7, 2025
19 checks passed
@ovflowd ovflowd deleted the chore-about-navigation branch June 7, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants