-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(navigation): re-order #7841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorders the sub-navigation items under the About section to follow the new logical sequence.
- Removes
brandingandgovernancefrom abovepreviousReleases - Inserts
securityReporting, thengovernance, thenbrandingafterpreviousReleases
Comments suppressed due to low confidence (2)
apps/site/navigation.json:112
- Consider adding or updating unit tests to validate this new navigation order to prevent regressions if items are modified in the future.
"securityReporting": {
apps/site/navigation.json:102
- [nitpick] To improve clarity for future maintainers, consider extracting the About sub-navigation order into a shared constant or adding a comment that explains the rationale behind this specific ordering.
"link": "/about",
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7841 +/- ##
==========================================
+ Coverage 75.46% 75.48% +0.02%
==========================================
Files 101 101
Lines 8305 8305
Branches 218 218
==========================================
+ Hits 6267 6269 +2
+ Misses 2036 2034 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
@nodejs/nodejs-website Seeing as this is a pretty straight forward change, I'm requesting
fast-track
|
|
Lighthouse Results
|
Description
IMO previous order of the navigation doesn't make sense.
The logic behind this is that
Related Issues
No related issue.
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.