fix(ui): sidebar css fixes #7843
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CSS bug in the Sidebar component by updating class names and selectors to ensure proper styling on mobile and navigation elements.
- Added CSS class names "mobileSelect" and "navigation" to the corresponding JSX elements in Sidebar.
- Updated CSS module selectors to replace descendant selectors with explicit class selectors.
- Modified SidebarGroup to accept and compose an additional "className" for styling enhancements.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/Containers/Sidebar/index.tsx | Added "mobileSelect" and "navigation" classes to facilitate responsive styling. |
| packages/ui-components/Containers/Sidebar/index.module.css | Replaced descendant selectors with explicit class selectors to match new JSX class names. |
| packages/ui-components/Containers/Sidebar/SidebarGroup/index.tsx | Updated component interface and merged additional "className" into the final class composition. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7843 +/- ##
==========================================
+ Coverage 75.44% 75.46% +0.01%
==========================================
Files 101 101
Lines 8305 8305
Branches 218 218
==========================================
+ Hits 6266 6267 +1
+ Misses 2037 2036 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Are you requesting fast-tracking? Please don't forget to comment that you are requesting fast-tracking :) |
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
LGTM. And +1 for fast-tracking if it was requested.
|
Yes, I was fast-tracking this, sorry |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
I merged #7840 too quickly, without waiting for a proper review (Sorry!). This fixes a CSS bug. Any other concerns can be resolved in a seperate PR, but let's get the css fixed first.