Skip to content

Conversation

@canerakdas
Copy link
Member

Description

Fixes the image rendering problem on; http://nodejs.org/en/blog/announcements/node-18-eol-support

Validation

Images must be rendered in the preview

Copilot AI review requested due to automatic review settings June 8, 2025 10:24
@canerakdas canerakdas requested a review from a team as a code owner June 8, 2025 10:24
@vercel
Copy link

vercel bot commented Jun 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 8, 2025 10:25am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the image rendering issue on the Node.js EOL support announcement page by updating the image reference paths.

  • Updates markdown image links from "/static/images/blob/..." to "/static/images/blog/..."
  • Ensures that the images render correctly in the preview
Comments suppressed due to low confidence (2)

apps/site/pages/en/blog/announcements/node-18-eol-support.md:90

  • Verify that '/static/images/blog/announcements/2025-eol-node-graph.png' is the correct path for the intended image location. If this update is due to a restructuring of image folders, please ensure consistency across similar references.
[image1]: /static/images/blog/announcements/2025-eol-node-graph.png

apps/site/pages/en/blog/announcements/node-18-eol-support.md:91

  • Verify that '/static/images/blog/announcements/2025-release-schedule.svg' is the correct updated path. Consistency in file path naming is crucial to ensure proper image rendering.
[image2]: /static/images/blog/announcements/2025-release-schedule.svg

@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (526a386) to head (4bdf015).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7847      +/-   ##
==========================================
+ Coverage   75.46%   75.47%   +0.01%     
==========================================
  Files         101      101              
  Lines        8305     8305              
  Branches      218      218              
==========================================
+ Hits         6267     6268       +1     
+ Misses       2036     2035       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jun 8, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 8, 2025
@avivkeller
Copy link
Member

Requesting fast track

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller enabled auto-merge June 8, 2025 10:26
@avivkeller avivkeller linked an issue Jun 8, 2025 that may be closed by this pull request
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avivkeller
Copy link
Member

@canerakdas Let's not wait for a releaser to approve this, I think it's okay to bypass merge protections.

@avivkeller avivkeller added this pull request to the merge queue Jun 8, 2025
Merged via the queue into nodejs:main with commit c375408 Jun 8, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

urgent - eol article does not have rendered images

4 participants