-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: node 18 eol support images #7847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node 18 eol support images #7847
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the image rendering issue on the Node.js EOL support announcement page by updating the image reference paths.
- Updates markdown image links from "/static/images/blob/..." to "/static/images/blog/..."
- Ensures that the images render correctly in the preview
Comments suppressed due to low confidence (2)
apps/site/pages/en/blog/announcements/node-18-eol-support.md:90
- Verify that '/static/images/blog/announcements/2025-eol-node-graph.png' is the correct path for the intended image location. If this update is due to a restructuring of image folders, please ensure consistency across similar references.
[image1]: /static/images/blog/announcements/2025-eol-node-graph.png
apps/site/pages/en/blog/announcements/node-18-eol-support.md:91
- Verify that '/static/images/blog/announcements/2025-release-schedule.svg' is the correct updated path. Consistency in file path naming is crucial to ensure proper image rendering.
[image2]: /static/images/blog/announcements/2025-release-schedule.svg
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7847 +/- ##
==========================================
+ Coverage 75.46% 75.47% +0.01%
==========================================
Files 101 101
Lines 8305 8305
Branches 218 218
==========================================
+ Hits 6267 6268 +1
+ Misses 2036 2035 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Requesting fast track |
|
Lighthouse Results
|
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@canerakdas Let's not wait for a releaser to approve this, I think it's okay to bypass merge protections. |
Description
Fixes the image rendering problem on; http://nodejs.org/en/blog/announcements/node-18-eol-support
Validation
Images must be rendered in the preview