-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(meta): clean up root #7852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up the repository's root directory by removing files that are no longer in use.
- Removed .pre-commit-config.yaml since pre-commit is replaced by Husky
- Removed .browserslistrc as it is not required by our service providers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Removed unused pre-commit configuration file |
| .browserslistrc | Removed browserslist configuration file |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7852 +/- ##
==========================================
- Coverage 75.46% 75.44% -0.02%
==========================================
Files 101 101
Lines 8305 8305
Branches 218 218
==========================================
- Hits 6267 6266 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if Next.js was meant to be consuming the browserslistrc, but its in the wrong location for that to make sense
|
Fast-tracking 👍 |
|
Lighthouse Results
|
As @ovflowd mentioned on Slack, our repository is quite complex (in various locations). This PR declutters our
[root]/directory by:.github, which is another valid locationpre-commit-config.yaml: We don't use pre-commit, we use Husky.browserslistrc. IIUC none of our service providers rely on this file.Along with #7837, this should help de-mystify parts of the codebase.