Skip to content

Conversation

@avivkeller
Copy link
Member

As @ovflowd mentioned on Slack, our repository is quite complex (in various locations). This PR declutters our [root]/ directory by:

  • Putting CODEOWNERS in .github, which is another valid location
  • Removing pre-commit-config.yaml: We don't use pre-commit, we use Husky
  • Remove .browserslistrc. IIUC none of our service providers rely on this file.

Along with #7837, this should help de-mystify parts of the codebase.

Copilot AI review requested due to automatic review settings June 8, 2025 20:13
@avivkeller avivkeller requested review from a team as code owners June 8, 2025 20:13
@vercel
Copy link

vercel bot commented Jun 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 8, 2025 8:13pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the repository's root directory by removing files that are no longer in use.

  • Removed .pre-commit-config.yaml since pre-commit is replaced by Husky
  • Removed .browserslistrc as it is not required by our service providers

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.pre-commit-config.yaml Removed unused pre-commit configuration file
.browserslistrc Removed browserslist configuration file

@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (4d1ce7b) to head (8b46540).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7852      +/-   ##
==========================================
- Coverage   75.46%   75.44%   -0.02%     
==========================================
  Files         101      101              
  Lines        8305     8305              
  Branches      218      218              
==========================================
- Hits         6267     6266       -1     
- Misses       2036     2037       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if Next.js was meant to be consuming the browserslistrc, but its in the wrong location for that to make sense

@ovflowd
Copy link
Member

ovflowd commented Jun 9, 2025

Fast-tracking 👍

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 9, 2025
@ovflowd ovflowd enabled auto-merge June 9, 2025 10:56
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@ovflowd ovflowd added this pull request to the merge queue Jun 9, 2025
Merged via the queue into main with commit a31b816 Jun 9, 2025
15 checks passed
@ovflowd ovflowd deleted the cleanup-root branch June 9, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants