fix: images for node 18 eol blog post #7856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the order of the images in the Node.js 18 EOL blog post so that the release schedule appears before the EOL graph.
- Swapped the image reference definitions to show the release schedule first, followed by the EOL graph.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7856 +/- ##
==========================================
+ Coverage 75.44% 75.48% +0.03%
==========================================
Files 101 101
Lines 8305 8305
Branches 218 218
==========================================
+ Hits 6266 6269 +3
+ Misses 2037 2034 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
avivkeller
approved these changes
Jun 10, 2025
github-actions
bot
removed
the
github_actions:pull-request
Member
|
Fast track requested |
Contributor
|
Lighthouse Results
|
marco-ippolito
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The images are not accurate on Node.js 18 EOL blog post.
The release schedule image should appear first, followed by EOL Node.js graph.
Validation
Check preview at https://nodejs-org-git-trivikr-patch-1-openjs.vercel.app/en/blog/announcements/node-18-eol-support
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.