Skip to content

Conversation

@kimpuro
Copy link
Contributor

@kimpuro kimpuro commented Jun 11, 2025

Description

Fixed a broken link in README.md
The issue appears to have been caused by a folder structure change introduced in PR #7837

Validation

  • Collaborator Guide
  • Content vs Code
  • Dependency Pinning
  • Translation Guidelines

You can check the above 4 links in README.md.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Dongeun Kim <puro@sooplive.com>
Copilot AI review requested due to automatic review settings June 11, 2025 10:47
@kimpuro kimpuro requested a review from a team as a code owner June 11, 2025 10:47
@vercel
Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 11, 2025 10:48am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken documentation links in README.md that were caused by a recent folder structure change.

  • Updates the URL for content vs code, dependency pinning, collaborator guide, and translation guidelines
  • Ensures that the links now point to the correct location in the docs folder

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @kimpuro

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fixes @kimpuro 😄

@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jun 11, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 92 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member

Fast tracking

@avivkeller avivkeller enabled auto-merge June 11, 2025 13:43
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (f93bd4b) to head (cf25040).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7858      +/-   ##
==========================================
+ Coverage   75.43%   75.44%   +0.01%     
==========================================
  Files         101      101              
  Lines        8305     8305              
  Branches      218      218              
==========================================
+ Hits         6265     6266       +1     
+ Misses       2038     2037       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jun 11, 2025
Merged via the queue into nodejs:main with commit 3ccf909 Jun 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants