Skip to content

Conversation

@SuperchupuDev
Copy link
Contributor

Description

done for consistency with the rest of the website
https://github.com/search?q=repo%3Anodejs%2Fnodejs.org%20their&type=code

(both his/her and her/his bring no results other than this one occurrence)

Validation

N/A (i suppose)

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Superchupu <53496941+SuperchupuDev@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 14, 2025 04:38
@SuperchupuDev SuperchupuDev requested a review from a team as a code owner June 14, 2025 04:38
@vercel
Copy link

vercel bot commented Jun 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 14, 2025 4:39am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the language in the documentation to use inclusive terminology by replacing "her/his" with "their".

  • Changes the phrasing in one instance on the publishing-a-package.mdx page to align with the style guidelines across the website.
Comments suppressed due to low confidence (1)

apps/site/pages/en/learn/modules/publishing-a-package.mdx:525

  • The language change to use 'their' improves inclusivity and aligns with overall documentation guidelines. Please ensure that any similar instances in other documentation pages are updated for consistency.
- Determining format of source code files (author running their own code)

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@avivkeller avivkeller added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Jun 14, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 14, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking

@avivkeller avivkeller enabled auto-merge June 14, 2025 04:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov
Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (41ed5ee) to head (29af58c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7865      +/-   ##
==========================================
+ Coverage   75.43%   75.46%   +0.02%     
==========================================
  Files         101      101              
  Lines        8306     8306              
  Branches      218      218              
==========================================
+ Hits         6266     6268       +2     
+ Misses       2038     2036       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jun 14, 2025
Merged via the queue into nodejs:main with commit 313e163 Jun 14, 2025
19 checks passed
@SuperchupuDev SuperchupuDev deleted the patch-1 branch June 14, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants