Skip to content

Conversation

@avivkeller
Copy link
Member

If/when the foundation controls the Figma, this can be changed, but for now we should give contributors an active link.

Fixes: #7872

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings June 17, 2025 21:44
@avivkeller avivkeller requested a review from a team as a code owner June 17, 2025 21:44
@vercel
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 17, 2025 9:44pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Figma design reference in the README to use an active link and corrects its markdown formatting.

  • Replaced the outdated Figma URL with a new active link
  • Removed the stray leading dash to fix the reference definition syntax
Comments suppressed due to low confidence (1)

README.md:124

  • The updated Figma link appears incomplete and may not point to the intended Node.js file. Please verify the full URL (including the file identifier) so it resolves correctly.
[figma design]: https://www.figma.com/file/8fG0oWFQArJ7C9WbC9n2wa

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (8cf10eb) to head (12c297a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7874      +/-   ##
==========================================
- Coverage   75.46%   75.45%   -0.02%     
==========================================
  Files         101      101              
  Lines        8306     8306              
  Branches      218      218              
==========================================
- Hits         6268     6267       -1     
- Misses       2036     2037       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

For website & infrastructure team members, or anyone else in the foundation that needs access to write, DM me your emails, and I’ll invite you to edit https://www.figma.com/file/8fG0oWFQArJ7C9WbC9n2wa

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jun 17, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@manishprivet manishprivet added the fast-track Fast Tracking PRs label Jun 17, 2025
@manishprivet
Copy link
Member

I believe we can fast track this as there is currently wrong information in the README.

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jun 17, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 17, 2025
@avivkeller avivkeller enabled auto-merge June 17, 2025 23:00
@avivkeller avivkeller added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit f137f85 Jun 17, 2025
24 checks passed
@avivkeller avivkeller deleted the Fixma branch June 17, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restricted Figma Link in README

5 participants