-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(meta): use active Figma link #7874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Figma design reference in the README to use an active link and corrects its markdown formatting.
- Replaced the outdated Figma URL with a new active link
- Removed the stray leading dash to fix the reference definition syntax
Comments suppressed due to low confidence (1)
README.md:124
- The updated Figma link appears incomplete and may not point to the intended Node.js file. Please verify the full URL (including the file identifier) so it resolves correctly.
[figma design]: https://www.figma.com/file/8fG0oWFQArJ7C9WbC9n2wa
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7874 +/- ##
==========================================
- Coverage 75.46% 75.45% -0.02%
==========================================
Files 101 101
Lines 8306 8306
Branches 218 218
==========================================
- Hits 6268 6267 -1
- Misses 2036 2037 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
For website & infrastructure team members, or anyone else in the foundation that needs access to write, DM me your emails, and I’ll invite you to edit https://www.figma.com/file/8fG0oWFQArJ7C9WbC9n2wa |
|
Lighthouse Results
|
|
I believe we can fast track this as there is currently wrong information in the README. |
If/when the foundation controls the Figma, this can be changed, but for now we should give contributors an active link.
Fixes: #7872