Skip to content

Conversation

@sajadtorkamani
Copy link
Contributor

CleanShot 2025-06-26 at 19 16 00

Signed-off-by: Sajad Torkamani <sajadtorkamani1@gmail.com>
Copilot AI review requested due to automatic review settings June 26, 2025 18:24
@sajadtorkamani sajadtorkamani requested a review from a team as a code owner June 26, 2025 18:24
@vercel
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 27, 2025 8:19pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the wording in the debugging documentation to improve clarity and consistency.

  • Added backticks around "host" and "port" in flag descriptions for clearer emphasis.
  • Ensured consistent formatting throughout the debugging flag table.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jun 27, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.47%. Comparing base (49d6584) to head (921e769).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7898   +/-   ##
=======================================
  Coverage   75.47%   75.47%           
=======================================
  Files         101      101           
  Lines        8311     8311           
  Branches      218      218           
=======================================
  Hits         6273     6273           
  Misses       2036     2036           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member

@sajadtorkamani Can you take a look at the linting errors?

@sajadtorkamani
Copy link
Contributor Author

sajadtorkamani commented Jun 27, 2025

@sajadtorkamani Can you take a look at the linting errors?

@avivkeller So sorry, it was lazy of me not to fix that 🙏

I've just ran pnpm prettier so hopefully it should be fine now:

CleanShot 2025-06-27 at 21 19 16@2x

@bjohansebas bjohansebas added the github_actions:pull-request Trigger Pull Request Checks label Jun 27, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 27, 2025
@AugustinMauroy AugustinMauroy added this pull request to the merge queue Jun 28, 2025
Merged via the queue into nodejs:main with commit 84fa725 Jun 28, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants