Skip to content

Conversation

@avivkeller
Copy link
Member

@nodejs/tsc @nodejs/marketing

Copilot AI review requested due to automatic review settings June 29, 2025 14:19
@avivkeller avivkeller requested a review from a team as a code owner June 29, 2025 14:19
@vercel
Copy link

vercel bot commented Jun 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org 🔄 Building (Inspect) Visit Preview Jun 29, 2025 2:19pm

@nodejs nodejs locked and limited conversation to collaborators Jun 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the site configuration to use the default logo by removing the custom "pride" logo variant.

  • Removal of the "logoVariant": "pride" line from the site configuration
  • Simplification of branding settings for consistency with the default appearance
Comments suppressed due to low confidence (1)

apps/site/site.json:5

  • Removing the 'logoVariant' property triggers the fallback to the default logo. Consider updating the documentation or adding an inline comment to explain this behavior for clarity and maintainability.
  "accentColor": "#333",

@avivkeller
Copy link
Member Author

Allowing 48 hours for review and visibility. This should land on or about July 1st

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Jun 29, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 29, 2025
@ovflowd
Copy link
Member

ovflowd commented Jun 29, 2025

Lighthouse failed?

@MattIPv4
Copy link
Member

Lighthouse failed?

It just failed to comment because the PR is locked

@nodejs nodejs unlocked this conversation Jun 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@nodejs nodejs locked and limited conversation to collaborators Jun 29, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Jul 1, 2025
@AugustinMauroy
Copy link
Member

We are the 1 jul in UTC

Merged via the queue into main with commit a591c0c Jul 1, 2025
20 of 21 checks passed
@AugustinMauroy AugustinMauroy deleted the avivkeller-patch-1 branch July 1, 2025 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants