feat(favicon): use standardized icon #7928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
I'll open a PR to change all the full logos once I finish making their SVGs with the newer icon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7928 +/- ##
==========================================
+ Coverage 75.40% 75.41% +0.01%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 219
==========================================
+ Hits 6299 6300 +1
+ Misses 2053 2052 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the site favicon and social preview to the updated icon, see #7880.
For the twitter card, I didn't know the exact dimensions of the icon to use, so I used:
rsvg-convert -w 212 -h 212 nodejs.svg | magick - -gravity center -extent 224x256 -background white logo-hexagon-card.png(A 212x212 icon in the middle of a 224x256 card)
CC @nodejs/marketing