Patch 2 #7936
Closed
Patch 2 #7936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
👀 I realise these are both small changes, but could you split the contributing docs change into a separate PR, please, so that your PRs contain logical changesets? |
Contributor
Author
Member
|
Closing in favor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed a few typos in the code snippets provided in the
Learn/Asynchronous Worksection.While working on the PR, a hyperlink to the pull request template was found to be broken in the docs. This PR fixed that also.
Validation
Typo
The function named
sendMail()is now mentioned correctly in the comment (instead ofsendEmail())Broken link
For the broken link, I can now jump to the correct file (
PULL_REQUEST_TEMPLATE.md) instead ofpull_request_template.mdwhile browsing in VS Code Markdown Preview.Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.