fix(lint): use --fix in .lintstagedrc
#7938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that CSS files are automatically fixed by Stylelint when staged.
- Added
--fixflag to Stylelint commands in lint-staged configs. - Updated both
packages/ui-componentsandapps/siteconfigurations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/.lintstagedrc.json | Add --fix to Stylelint for CSS files |
| apps/site/.lintstagedrc.json | Add --fix to Stylelint for CSS files |
Comments suppressed due to low confidence (2)
packages/ui-components/.lintstagedrc.json:3
- [nitpick] The CSS lint-staged command is duplicated in multiple packages; consider centralizing this into a shared root configuration to reduce duplication and simplify future updates.
"**/*.css": ["stylelint --allow-empty-input --fix", "prettier --write"],
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7938 +/- ##
==========================================
+ Coverage 75.40% 75.43% +0.03%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 219
==========================================
+ Hits 6299 6302 +3
+ Misses 2053 2050 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
bjohansebas
approved these changes
Jul 3, 2025
AugustinMauroy
approved these changes
Jul 3, 2025
ovflowd
approved these changes
Jul 3, 2025
Member
|
Fast-tracking as hot-fix! cc @nodejs/nodejs-website |
ovflowd
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing #7937, I realized that our
.lintstagedrc.jsonfiles were not performing automatic stylelint fixes when possible