Skip to content

Conversation

@avivkeller
Copy link
Member

🫣 Must've included this in a PR by accident

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings July 3, 2025 23:43
@avivkeller avivkeller requested a review from a team as a code owner July 3, 2025 23:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@vercel
Copy link

vercel bot commented Jul 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 3, 2025 11:43pm

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.42%. Comparing base (d94cf3e) to head (bf60240).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7947      +/-   ##
==========================================
+ Coverage   75.40%   75.42%   +0.02%     
==========================================
  Files          96       96              
  Lines        8354     8354              
  Branches      219      219              
==========================================
+ Hits         6299     6301       +2     
+ Misses       2053     2051       -2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

@dario-piotrowicz https://github.com/nodejs/nodejs.org/actions/runs/16062567733/job/45331245226#step:11:1 👀

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz https://github.com/nodejs/nodejs.org/actions/runs/16062567733/job/45331245226#step:11:1 👀

weird.... 😕

Thanks for the ping @avivkeller 🙏

I've re run the job and it passed... so 🤷

I'll open a PR later to also log the webServer output, it'll be more verbose but hopefully it should give us a bit more info for when something is going wrong

@ovflowd
Copy link
Member

ovflowd commented Jul 4, 2025

Fast-tracking because... Well.. Y'a know. (cc @nodejs/nodejs-website)

@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 4, 2025
@ovflowd ovflowd enabled auto-merge July 4, 2025 13:42
@ovflowd ovflowd added this pull request to the merge queue Jul 4, 2025
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 4, 2025
Merged via the queue into main with commit 4ebead0 Jul 4, 2025
20 of 21 checks passed
@ovflowd ovflowd deleted the chore/delete-empty-file branch July 4, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants