-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(publish): third time’s the charm #7959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a missing dependency installation step to the publish workflow before bumping the package version.
- Introduce a
pnpm install --frozen-lockfilestep - Annotate the install step with a comment
Comments suppressed due to low confidence (2)
.github/workflows/publish-packages.yml:121
- [nitpick] Consider spelling out 'dependencies' instead of using the abbreviation 'deps' for clarity in comments.
# Install deps
.github/workflows/publish-packages.yml:122
- [nitpick] To speed up the workflow, consider adding a cache step for pnpm store or node_modules before running the install.
pnpm install --frozen-lockfile
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7959 +/- ##
==========================================
+ Coverage 73.68% 73.71% +0.02%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 219
==========================================
+ Hits 6156 6158 +2
+ Misses 2197 2195 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Approving fast tracking! |
|
Sorry again for these follow-ups! Hopefully this is the last one! |
Requesting fast track.
Okay, third time's the charm.