feat(learn): setTimeout() return type #7960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avivkeller
changed the title
Member
|
Please add the other author as a Co-Author |
AugustinMauroy
approved these changes
Jul 8, 2025
ShubhamOulkar
force-pushed
the
update-timers-return-type
branch
from
eddf3a6 to
a87381a
Compare
Co-authored-by: Aviv Keller <me@aviv.sh> Co-authored-by: vishal <vishalkumarvkvk988@gmail.com>
ShubhamOulkar
force-pushed
the
update-timers-return-type
branch
from
a87381a to
5ae63d1
Compare
bjohansebas
approved these changes
Jul 9, 2025
github-actions
bot
removed
the
github_actions:pull-request
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7960 +/- ##
==========================================
- Coverage 73.68% 73.64% -0.05%
==========================================
Files 96 96
Lines 8354 8354
Branches 219 220 +1
==========================================
- Hits 6156 6152 -4
- Misses 2197 2201 +4
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rebase of #7759
Docs validation
https://developer.mozilla.org/en-US/docs/Web/API/Window/setTimeout#return_value
https://nodejs.org/api/timers.html#class-timeout
Related Issues
closes #7672
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.