learn: fix net module import in server and client example #7975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avivkeller
approved these changes
Jul 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7975 +/- ##
==========================================
- Coverage 73.68% 73.09% -0.60%
==========================================
Files 96 95 -1
Lines 8354 8355 +1
Branches 219 219
==========================================
- Hits 6156 6107 -49
- Misses 2197 2247 +50
Partials 1 1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced incorrect destructured import with default import for the 'net' module.
Old:
import { net } from 'node:net'
Corrected to:
import net from 'node:net'
This fix applies to the server and client example for mjs on this page :-
https://nodejs.org/en/learn/modules/how-to-use-streams#key-methods-and-events-in-duplex-streams