chore: next.js 15.4 #7981
chore: next.js 15.4 #7981
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Next.js build pipeline by enabling Turbopack in the default build and bumps the Next.js dependency to v15.4.1.
- Adds
--turboflag tobuild:defaultscript - Bumps
nextfrom 15.3.4 to 15.4.1
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
apps/site/package.json:9
- Consider adding or updating tests to verify that the build process with the
--turboflag completes successfully and produces the expected output.
"build:default": "cross-env NODE_NO_WARNINGS=1 next build --turbo",
apps/site/package.json:6
- [nitpick] Since
build:defaultnow always includes the--turboflag, the top-levelbuildscript is passing it redundantly; you could simplify it tonode --run build:default.
"build": "node --run build:default -- --turbo",
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7981 +/- ##
==========================================
- Coverage 73.10% 73.08% -0.03%
==========================================
Files 95 95
Lines 8355 8355
Branches 219 219
==========================================
- Hits 6108 6106 -2
- Misses 2246 2248 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
I don't think turbo has been unflagged.
With that in mind, why not wait for Dependabot to do this?
Why not use it? Supposedly it passes all the tests, right? I understand there might still be risks until it stabilizes and has been tested for a while, so I get why we don't want to use Turbopack in the builds yet.
i don't know 🤷, i got hyped haha |
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
Please don't change random things and let Dependabot do its job lol
| "build:blog-data": "cross-env NODE_NO_WARNINGS=1 node ./scripts/blog-data/generate.mjs", | ||
| "build:blog-data:watch": "node --watch --watch-path=pages/en/blog ./scripts/blog-data/generate.mjs", | ||
| "build:default": "cross-env NODE_NO_WARNINGS=1 next build", | ||
| "build:default": "cross-env NODE_NO_WARNINGS=1 next build --turbo", |
There was a problem hiding this comment.
Why are you changing this line? This has nothing to do with Turbopack being stable or not. Open Next is not compatible with Turbopack.
There was a problem hiding this comment.
Between open-next and next, I'm already starting to get confused.
|
Okay, I got carried away haha, I'm going to close it |
Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.