fix(CodeTabs): name overrides, duplicate name titles #7994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the CodeTabs component by implementing name overrides (renaming "MJS" to "ESM") and handling duplicate tab names by appending count suffixes like "(1)", "(2)".
Key changes:
- Adds a NAME_OVERRIDES mapping to standardize language display names
- Implements duplicate name detection and numbering system
- Refactors tab label generation logic to handle both overrides and duplicates
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7994 +/- ##
==========================================
- Coverage 73.15% 73.13% -0.02%
==========================================
Files 95 95
Lines 8354 8354
Branches 218 218
==========================================
- Hits 6111 6110 -1
- Misses 2242 2243 +1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aviv Keller <me@aviv.sh>
AugustinMauroy
approved these changes
Jul 19, 2025
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
LGMT ! Do we have test for this component ?
araujogui
approved these changes
Jul 19, 2025
github-actions
bot
removed
the
github_actions:pull-request
Contributor
|
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/node#52343 (comment)
Ref: nodejs/node#52343 (comment)
This PR renames
MJStoESM, and adds a(1)(etc) when multiple identically titled codetabs are used.