-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
ci: disable is-crawlable audit in Lighthouse #8011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables the Lighthouse "is-crawlable" audit to prevent build preview failures where the indexing check consistently fails due to the preview environment context.
- Adds configuration to turn off the is-crawlable audit in Lighthouse CI
- Aims to improve Lighthouse scores by removing a consistently failing audit from build previews
|
Lighthouse Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8011 +/- ##
==========================================
+ Coverage 72.99% 73.00% +0.01%
==========================================
Files 95 95
Lines 8317 8317
Branches 214 214
==========================================
+ Hits 6071 6072 +1
+ Misses 2245 2244 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hm, Lighthouse run in this PR is still showing the audit as failing 🤔 |
Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
|
🎉 Much better |
|
Fast-tracking as a hotfix. |
Description
Disables the indexing audit for Lighthouse, as this always fails in our build previews.
Validation
See if Lighthouse reports a better score w/o the indexing warning.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.