Skip to content

Conversation

@MattIPv4
Copy link
Member

Description

Disables the indexing audit for Lighthouse, as this always fails in our build previews.

Validation

See if Lighthouse reports a better score w/o the indexing warning.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
Copilot AI review requested due to automatic review settings July 22, 2025 15:07
@MattIPv4 MattIPv4 requested a review from a team as a code owner July 22, 2025 15:07
@vercel
Copy link

vercel bot commented Jul 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 22, 2025 3:15pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables the Lighthouse "is-crawlable" audit to prevent build preview failures where the indexing check consistently fails due to the preview environment context.

  • Adds configuration to turn off the is-crawlable audit in Lighthouse CI
  • Aims to improve Lighthouse scores by removing a consistently failing audit from build previews

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 90 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (2a2aa16) to head (8eab85e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8011      +/-   ##
==========================================
+ Coverage   72.99%   73.00%   +0.01%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      214      214              
==========================================
+ Hits         6071     6072       +1     
+ Misses       2245     2244       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4
Copy link
Member Author

Hm, Lighthouse run in this PR is still showing the audit as failing 🤔

Signed-off-by: Matt Cowley <me@mattcowley.co.uk>
@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 22, 2025
@MattIPv4
Copy link
Member Author

🎉 Much better

@ovflowd ovflowd added this pull request to the merge queue Jul 22, 2025
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 22, 2025
@ovflowd
Copy link
Member

ovflowd commented Jul 22, 2025

Fast-tracking as a hotfix.

Merged via the queue into main with commit 500de4c Jul 22, 2025
18 checks passed
@ovflowd ovflowd deleted the MattIPv4/disable-lighthouse-is-crawlable branch July 22, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants