Skip to content

Conversation

@nitin-is-me
Copy link
Contributor

@nitin-is-me nitin-is-me commented Jul 23, 2025

Description

This PR improves documentation clarity by:

  • Expanding "TSC" to "Technical Steering Committee" for better understanding
  • Fixing a typo in the next.rwrites.mjs section
  • Clarifying fallback behavior in next.dynamic.mjs
  • Adding the official Playwright documentation link to the testing section

Validation

Manually reviewed rendered markdown and verified that links work and text is clearer.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing. (N/A)
  • I have run pnpm build to check if the website builds without errors. (N/A)
  • I've covered new added functionality with unit tests if necessary. (N/A)

Signed-off-by: Nitin <nitinjha2609@gmail.com>
Signed-off-by: Nitin <nitinjha2609@gmail.com>
Signed-off-by: Nitin <nitinjha2609@gmail.com>
Signed-off-by: Nitin <nitinjha2609@gmail.com>
@nitin-is-me nitin-is-me requested review from a team as code owners July 23, 2025 13:40
@vercel
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 25, 2025 11:44pm

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 96 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@avivkeller avivkeller enabled auto-merge July 25, 2025 22:09
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.01%. Comparing base (f76285a) to head (a06c8b9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8013      +/-   ##
==========================================
+ Coverage   72.98%   73.01%   +0.03%     
==========================================
  Files          95       95              
  Lines        8324     8324              
  Branches      215      214       -1     
==========================================
+ Hits         6075     6078       +3     
+ Misses       2248     2245       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jul 25, 2025
@avivkeller avivkeller removed this pull request from the merge queue due to a manual request Jul 25, 2025
@avivkeller
Copy link
Member

@nitin-is-me Please rebase, when you get a chance

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@nitin-is-me
Copy link
Contributor Author

Hi @avivkeller, thanks for the heads-up! It looks like the main branch was merged into this one already by @ovflowd.

@mikeesto mikeesto added this pull request to the merge queue Jul 26, 2025
Merged via the queue into nodejs:main with commit b22252d Jul 26, 2025
14 checks passed
@nitin-is-me nitin-is-me deleted the improve-doc branch July 26, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants