Skip to content

Conversation

@MattIPv4
Copy link
Member

Description

Reduces the risk from compromised dependency versions by requiring that they've been published for at least three days before Dependabot will update us to them, giving time for maintainers and the community to spot and resolve compromises.

Validation

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/dependabot-options-reference#cooldown-

Related Issues

nodejs/web-team#25

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings July 24, 2025 00:37
@MattIPv4 MattIPv4 requested a review from a team as a code owner July 24, 2025 00:37
@vercel
Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) Jul 24, 2025 0:37am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a 3-day cooldown period for Dependabot updates to improve security by delaying dependency updates until they've been published for at least three days, allowing time to identify and resolve potential compromises.

  • Adds cooldown configuration with default-days: 3 to both GitHub Actions and npm package ecosystems
  • Enhances security posture by preventing immediate adoption of potentially compromised dependency versions

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.00%. Comparing base (331ad08) to head (1dc94b1).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8016      +/-   ##
==========================================
- Coverage   73.01%   73.00%   -0.02%     
==========================================
  Files          95       95              
  Lines        8317     8317              
  Branches      214      214              
==========================================
- Hits         6073     6072       -1     
- Misses       2243     2244       +1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! I never heard about that but it's super cool

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 25, 2025
@MattIPv4 MattIPv4 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into main with commit d26a294 Jul 25, 2025
14 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/dependabot-cooldown branch July 25, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants