Skip to content

Conversation

@Mohit5Upadhyay
Copy link
Contributor

Description

This pull request addresses a visual inconsistency in the hover styling and resolve issue : #8034

Validation

consistent-hover.mp4

Related Issues

Fixes #8034

Check List

  • [✅] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [✅] I have run pnpm format to ensure the code follows the style guide.
  • [✅] I have run pnpm test to check if all tests are passing.
  • [✅] I have run pnpm build to check if the website builds without errors.
  • [✅] I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings July 26, 2025 07:46
@Mohit5Upadhyay Mohit5Upadhyay requested a review from a team as a code owner July 26, 2025 07:46
@vercel
Copy link

vercel bot commented Jul 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 26, 2025 3:42pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes a visual inconsistency in the hover styling for sidebar items by adjusting the dark mode background color from dark:bg-neutral-800 to dark:bg-neutral-900 to ensure consistent hover effects.

  • Updates dark mode hover background color for sidebar items to achieve visual consistency

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller 👋,

This PR addresses the hover styling inconsistency mentioned in #8034.

&:not(.progression) .label {
      @apply rounded-sm
          ....
        // previously 
         dark:bg-neutral-800

        // updated
        dark:bg-neutral-900
          ....
    }

Let me know if any changes are needed.
Thanks for reviewing! 🙌

@avivkeller avivkeller changed the title fix: implementing consistent :hover styling (#8034) fix(css): consistent :hover styles Jul 26, 2025
@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller,

I've added the comment linking the hover style as requested. Please take a look when you have a moment.
Thanks again! 🙌

@Mohit5Upadhyay
Copy link
Contributor Author

Hi @avivkeller,
I've added the @see reference as suggested.
Let me know if any further adjustments are needed.
Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 94 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.98%. Comparing base (b22252d) to head (b5ae809).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8036      +/-   ##
==========================================
- Coverage   73.04%   72.98%   -0.07%     
==========================================
  Files          95       95              
  Lines        8324     8324              
  Branches      214      215       +1     
==========================================
- Hits         6080     6075       -5     
- Misses       2243     2248       +5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jul 29, 2025
Merged via the queue into nodejs:main with commit cb0d824 Jul 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:hover styling should be consistent

2 participants