-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(css): consistent :hover styles
#8036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): consistent :hover styles
#8036
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request fixes a visual inconsistency in the hover styling for sidebar items by adjusting the dark mode background color from dark:bg-neutral-800 to dark:bg-neutral-900 to ensure consistent hover effects.
- Updates dark mode hover background color for sidebar items to achieve visual consistency
|
Hi @avivkeller 👋, This PR addresses the hover styling inconsistency mentioned in #8034. Let me know if any changes are needed. |
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css
Show resolved
Hide resolved
:hover styles
|
Hi @avivkeller, I've added the comment linking the hover style as requested. Please take a look when you have a moment. |
packages/ui-components/src/Containers/Sidebar/SidebarItem/index.module.css
Outdated
Show resolved
Hide resolved
|
Hi @avivkeller, |
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8036 +/- ##
==========================================
- Coverage 73.04% 72.98% -0.07%
==========================================
Files 95 95
Lines 8324 8324
Branches 214 215 +1
==========================================
- Hits 6080 6075 -5
- Misses 2243 2248 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Description
This pull request addresses a visual inconsistency in the hover styling and resolve issue : #8034
Validation
consistent-hover.mp4
Related Issues
Fixes #8034
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.