-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: minor mdx component arrangement and type fix #8041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves MDX component organization and adds type safety by adding the missing @types/mdx package, reorganizing component exports between client and server MDX configurations, and implementing memoization for performance optimization in the CodeTabs component.
- Adds
@types/mdxpackage and TypeScript configuration for better MDX type checking - Moves shared components (Button, Link, LinkWithArrow) from client-side to server-side MDX configuration
- Optimizes CodeTabs component with useMemo to prevent unnecessary recalculations
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/MDX/CodeTabs.tsx | Adds memoization for tabs and languages calculation and reorganizes variable placement |
| apps/site/tsconfig.json | Enables MDX type checking configuration |
| apps/site/package.json | Adds @types/mdx dependency for TypeScript support |
| apps/site/next.mdx.use.mjs | Adds Button, Link, and LinkWithArrow components to server-side MDX configuration |
| apps/site/next.mdx.use.client.mjs | Removes Button, Link, and LinkWithArrow components from client-side configuration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8041 +/- ##
==========================================
- Coverage 73.02% 72.99% -0.04%
==========================================
Files 95 95
Lines 8324 8324
Branches 214 215 +1
==========================================
- Hits 6079 6076 -3
- Misses 2244 2247 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Copilot, otherwise, lgtm
|
Lighthouse Results
|
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
This PR is a minor update to correct a missing mdx type package; organize some exports correctly and some minor memoization.