Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 28, 2025

This PR is a minor update to correct a missing mdx type package; organize some exports correctly and some minor memoization.

Copilot AI review requested due to automatic review settings July 28, 2025 23:40
@ovflowd ovflowd requested review from a team as code owners July 28, 2025 23:40
@vercel
Copy link

vercel bot commented Jul 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 29, 2025 10:41am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves MDX component organization and adds type safety by adding the missing @types/mdx package, reorganizing component exports between client and server MDX configurations, and implementing memoization for performance optimization in the CodeTabs component.

  • Adds @types/mdx package and TypeScript configuration for better MDX type checking
  • Moves shared components (Button, Link, LinkWithArrow) from client-side to server-side MDX configuration
  • Optimizes CodeTabs component with useMemo to prevent unnecessary recalculations

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/ui-components/src/MDX/CodeTabs.tsx Adds memoization for tabs and languages calculation and reorganizes variable placement
apps/site/tsconfig.json Enables MDX type checking configuration
apps/site/package.json Adds @types/mdx dependency for TypeScript support
apps/site/next.mdx.use.mjs Adds Button, Link, and LinkWithArrow components to server-side MDX configuration
apps/site/next.mdx.use.client.mjs Removes Button, Link, and LinkWithArrow components from client-side configuration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.99%. Comparing base (c39cd36) to head (d43e791).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8041      +/-   ##
==========================================
- Coverage   73.02%   72.99%   -0.04%     
==========================================
  Files          95       95              
  Lines        8324     8324              
  Branches      214      215       +1     
==========================================
- Hits         6079     6076       -3     
- Misses       2244     2247       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Copilot, otherwise, lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

ovflowd added 2 commits July 29, 2025 12:29
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
@canerakdas canerakdas added the github_actions:pull-request Trigger Pull Request Checks label Jul 29, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 29, 2025
@avivkeller avivkeller added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit d93633a Jul 30, 2025
18 checks passed
@avivkeller avivkeller deleted the chore/minor-mdx-fix branch July 30, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants