-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(a11y): add correct aria-label on ThemeToggle button
#8045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
57fc929 to
ee52ede
Compare
ee52ede to
fe4dd3d
Compare
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my nitpicks above, lgtm
|
Lighthouse Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8045 +/- ##
==========================================
- Coverage 73.01% 72.82% -0.20%
==========================================
Files 95 96 +1
Lines 8324 8328 +4
Branches 214 214
==========================================
- Hits 6078 6065 -13
- Misses 2245 2262 +17
Partials 1 1 ☔ View full report in Codecov by Sentry. |
avivkeller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me
Added a11y test for
aria-labelin d47d496.Hydration mismatch:- Initially
resolvedThemeis undefined which is rendering wrong aria-label. Fixed in 61e8ea3 by excluding from SSR. And technically, theme component should be rendered on the client.closes #8044
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.