Skip to content

Conversation

@ShubhamOulkar
Copy link
Contributor

@ShubhamOulkar ShubhamOulkar commented Jul 29, 2025

Added a11y test for aria-label in d47d496.

Hydration mismatch:- Initially resolvedTheme is undefined which is rendering wrong aria-label. Fixed in 61e8ea3 by excluding from SSR. And technically, theme component should be rendered on the client.

closes #8044

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@ShubhamOulkar ShubhamOulkar requested a review from a team as a code owner July 29, 2025 15:06
@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 3, 2025 7:03am

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my nitpicks above, lgtm

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 31, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 94 🟢 100 🟢 96 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.82%. Comparing base (cb0d824) to head (61e8ea3).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8045      +/-   ##
==========================================
- Coverage   73.01%   72.82%   -0.20%     
==========================================
  Files          95       96       +1     
  Lines        8324     8328       +4     
  Branches      214      214              
==========================================
- Hits         6078     6065      -13     
- Misses       2245     2262      +17     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Aug 2, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 2, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me

@avivkeller avivkeller enabled auto-merge August 12, 2025 23:31
@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Aug 12, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 12, 2025
@avivkeller avivkeller added this pull request to the merge queue Aug 12, 2025
Merged via the queue into nodejs:main with commit 0293ad9 Aug 12, 2025
19 checks passed
@ShubhamOulkar ShubhamOulkar deleted the fix-ThemeToggle-a11y branch August 13, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: aria-label on ThemeToggle does not reflect current theme

4 participants