-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(turbo): don't recurse #8046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes recursive turbo calls from package.json scripts to prevent turbo from calling itself. The changes replace turbo run commands with node --run to execute scripts directly, addressing a specific issue with turbo recursion mentioned in the OpenJS Foundation Slack.
- Replaces
turbo runwithnode --runcommands in lint scripts across all packages - Introduces separate lint:fix commands for different linting tools (JS, CSS, MD)
- Restructures lint commands to use sequential execution with
&&operators
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ui-components/package.json | Updates lint commands to use node --run instead of turbo, adds separate CSS and JS fix commands |
| packages/rehype-shiki/package.json | Replaces turbo with node --run for JS linting and adds dedicated JS fix command |
| packages/i18n/package.json | Changes turbo lint command to node --run and adds JS-specific fix command |
| apps/site/package.json | Updates lint commands to use node --run with sequential execution and adds separate fix commands for each linting tool |
Comments suppressed due to low confidence (1)
packages/i18n/package.json:16
- The original command uses 'turbo lint:js' (without 'run'), but the replacement uses 'node --run lint:js'. This changes the behavior - the original was calling turbo's lint:js task, while the new command runs the local lint:js script.
"lint": "node --run lint:js",
|
Requesting fast-track, as this is a bug fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8046 +/- ##
==========================================
+ Coverage 73.01% 73.04% +0.02%
==========================================
Files 95 95
Lines 8324 8324
Branches 214 214
==========================================
+ Hits 6078 6080 +2
+ Misses 2245 2243 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. |
e7d7b2a to
1c940ee
Compare
|
Lighthouse Results
|
|
@anthonyshew OOC, it is still expected for each package to have their own turbo.json? |
Ref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1753785491329719
This PR changes our subdirectories to not call turbo, and instead rely on
node --run, as to prevent turbo recursively calling itself.