Skip to content

Conversation

@avivkeller
Copy link
Member

Ref: https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1753785491329719

This PR changes our subdirectories to not call turbo, and instead rely on node --run, as to prevent turbo recursively calling itself.

Copilot AI review requested due to automatic review settings July 29, 2025 18:31
@avivkeller avivkeller requested a review from a team as a code owner July 29, 2025 18:31
@vercel
Copy link

vercel bot commented Jul 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 29, 2025 6:34pm

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jul 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes recursive turbo calls from package.json scripts to prevent turbo from calling itself. The changes replace turbo run commands with node --run to execute scripts directly, addressing a specific issue with turbo recursion mentioned in the OpenJS Foundation Slack.

  • Replaces turbo run with node --run commands in lint scripts across all packages
  • Introduces separate lint:fix commands for different linting tools (JS, CSS, MD)
  • Restructures lint commands to use sequential execution with && operators

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/ui-components/package.json Updates lint commands to use node --run instead of turbo, adds separate CSS and JS fix commands
packages/rehype-shiki/package.json Replaces turbo with node --run for JS linting and adds dedicated JS fix command
packages/i18n/package.json Changes turbo lint command to node --run and adds JS-specific fix command
apps/site/package.json Updates lint commands to use node --run with sequential execution and adds separate fix commands for each linting tool
Comments suppressed due to low confidence (1)

packages/i18n/package.json:16

  • The original command uses 'turbo lint:js' (without 'run'), but the replacement uses 'node --run lint:js'. This changes the behavior - the original was calling turbo's lint:js task, while the new command runs the local lint:js script.
    "lint": "node --run lint:js",

@avivkeller
Copy link
Member Author

Requesting fast-track, as this is a bug fix

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.04%. Comparing base (cb0d824) to head (1c940ee).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8046      +/-   ##
==========================================
+ Coverage   73.01%   73.04%   +0.02%     
==========================================
  Files          95       95              
  Lines        8324     8324              
  Branches      214      214              
==========================================
+ Hits         6078     6080       +2     
+ Misses       2245     2243       -2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 98 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@ovflowd
Copy link
Member

ovflowd commented Jul 29, 2025

@anthonyshew OOC, it is still expected for each package to have their own turbo.json?

@ovflowd ovflowd added this pull request to the merge queue Aug 2, 2025
Merged via the queue into main with commit b8e314e Aug 2, 2025
19 of 20 checks passed
@ovflowd ovflowd deleted the fix/turbo-recurse branch August 2, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants