Skip to content

Conversation

@MattIPv4
Copy link
Member

Description

We've finally got the vanity invite URL, discord.gg/nodejs, so let's use that as the canonical invite on the site.

Validation

Links to join the Discord server still work.

Related Issues

N/A

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Status Preview Updated (UTC)
nodejs-org Ready Visit Preview Aug 11, 2025 8:57pm

Copilot AI review requested due to automatic review settings August 11, 2025 18:09
@MattIPv4 MattIPv4 requested review from a team as code owners August 11, 2025 18:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Discord invitation links across the Node.js website to use the new vanity URL discord.gg/nodejs instead of the previous URL.

  • Updates redirect configuration to use the new vanity URL
  • Replaces direct Discord links in navigation and documentation
  • Ensures consistent use of the canonical invite URL across all site content

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
redirects.json Updates redirect rules for /discord paths to use new vanity URL
2025-pride.md Replaces direct Discord link in blog post with new vanity URL
official-discord-launch-announcement.md Updates Discord links in announcement post to use new vanity URL
get-involved/index.md Changes Discord server link in community involvement documentation
navigation.json Updates Discord link in site navigation to use new vanity URL

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.81%. Comparing base (2e4a6d2) to head (80aea23).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8069      +/-   ##
==========================================
+ Coverage   72.80%   72.81%   +0.01%     
==========================================
  Files          96       96              
  Lines        8328     8328              
  Branches      214      214              
==========================================
+ Hits         6063     6064       +1     
+ Misses       2264     2263       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MattIPv4
Copy link
Member Author

Two open questions from me on this:

  1. Should I update the links in translations as part of this?
grep -R '(/discord)' apps/site    
apps/site/pages/ja/about/get-involved/index.md:- Node.jsの[公式Discordサーバー](/discord)ではNode.js開発者とチャットしたりNode.jsプロジェクトからのニュースを知ることができます。
apps/site/pages/ro/about/get-involved/index.md:- [Serverul oficial Discord](/discord) Node.js este un loc unde poți discuta cu alți dezvoltatori Node.js și poți primi știri oficiale despre proiectul Node.js.
apps/site/pages/uk/about/get-involved/index.md:- [Офіційний Discord‑сервер Node.js](/discord) — це місце для спілкування з іншими розробниками Node.js та отримання офіційних новин проєкту Node.js.
apps/site/pages/zh-tw/about/get-involved/index.md:- Node.js 的 [官方 Discord 伺服器](/discord) 是個可以與其他 Node.js 開發者交流並取得關於 Node.js 專案最新官方資訊的地方。
apps/site/pages/id/about/get-involved/index.md:- [Discord server resmi](/discord) Node.js adalah tempat berbincang dengan orang pengembang Node.js lain dan mendapatkan kabar resmi dari proyek Node.js.
apps/site/pages/fr/about/get-involved/index.md:- Le [serveur Discord officiel de Node.js](/discord) est un endroit pour discuter avec d'autres développeurs Node.js et obtenir des nouvelles officielles du projet Node.js.
apps/site/pages/es/about/get-involved/index.md:- El [servidor oficial de Discord de Node.js](/discord) es un lugar para charlar con otros desarrolladores de Node.js y recibir noticias oficiales del proyecto Node.js.
  1. Two translations have really old content that still refers to the Discord server as Nodeiflux, what should be done about those?
grep -R 'vUsrbjd' apps/site
apps/site/pages/zh-cn/about/get-involved/index.md:- [Nodeiflux](https://discordapp.com/invite/vUsrbjd) 是一个在Discord上互相友好讨论的 Node.js 后端开发者社区
apps/site/pages/fa/about/get-involved/index.md:- [Nodeiflux](https://discordapp.com/invite/vUsrbjd) یک جامعه دوستانه از توسعه‌دهندگان بک‌اند Node.js است که در Discord از یکدیگر پشتیبانی می‌کنند.

@MattIPv4 MattIPv4 added the github_actions:pull-request Trigger Pull Request Checks label Aug 11, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 95 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@AugustinMauroy
Copy link
Member

Two open questions from me on this:

  1. Should I update the links in translations as part of this?

grep -R '(/discord)' apps/site    

apps/site/pages/ja/about/get-involved/index.md:- Node.jsの[公式Discordサーバー](/discord)ではNode.js開発者とチャットしたりNode.jsプロジェクトからのニュースを知ることができます。

apps/site/pages/ro/about/get-involved/index.md:- [Serverul oficial Discord](/discord) Node.js este un loc unde poți discuta cu alți dezvoltatori Node.js și poți primi știri oficiale despre proiectul Node.js.

apps/site/pages/uk/about/get-involved/index.md:- [Офіційний Discord‑сервер Node.js](/discord) — це місце для спілкування з іншими розробниками Node.js та отримання офіційних новин проєкту Node.js.

apps/site/pages/zh-tw/about/get-involved/index.md:- Node.js 的 [官方 Discord 伺服器](/discord) 是個可以與其他 Node.js 開發者交流並取得關於 Node.js 專案最新官方資訊的地方。

apps/site/pages/id/about/get-involved/index.md:- [Discord server resmi](/discord) Node.js adalah tempat berbincang dengan orang pengembang Node.js lain dan mendapatkan kabar resmi dari proyek Node.js.

apps/site/pages/fr/about/get-involved/index.md:- Le [serveur Discord officiel de Node.js](/discord) est un endroit pour discuter avec d'autres développeurs Node.js et obtenir des nouvelles officielles du projet Node.js.

apps/site/pages/es/about/get-involved/index.md:- El [servidor oficial de Discord de Node.js](/discord) es un lugar para charlar con otros desarrolladores de Node.js y recibir noticias oficiales del proyecto Node.js.

  1. Two translations have really old content that still refers to the Discord server as Nodeiflux, what should be done about those?

grep -R 'vUsrbjd' apps/site

apps/site/pages/zh-cn/about/get-involved/index.md:- [Nodeiflux](https://discordapp.com/invite/vUsrbjd) 是一个在Discord上互相友好讨论的 Node.js 后端开发者社区

apps/site/pages/fa/about/get-involved/index.md:- [Nodeiflux](https://discordapp.com/invite/vUsrbjd) یک جامعه دوستانه از توسعه‌دهندگان بک‌اند Node.js است که در Discord از یکدیگر پشتیبانی می‌کنند.

In general we don't update translation. @bmuenzenmeyer do you have the permission to force changes on crowdin ?

@ovflowd
Copy link
Member

ovflowd commented Aug 11, 2025

Should I update the links in translations as part of this?

Since it is just the link, yes.

Two translations have really old content that still refers to the Discord server as Nodeiflux, what should be done about those?

Delete the pages.

@MattIPv4 MattIPv4 force-pushed the MattIPv4/update-nodejs-invite branch from 38bb69a to 80aea23 Compare August 11, 2025 20:54
@github-actions

This comment was marked as off-topic.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM !

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Aug 12, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 12, 2025
@avivkeller

This comment was marked as outdated.

@MattIPv4

This comment was marked as outdated.

@avivkeller

This comment was marked as outdated.

@MattIPv4
Copy link
Member Author

Marking this as blocked -- discord.gg/nodejs appears to suddenly no longer be working again

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link LGTM

@avivkeller
Copy link
Member

discord.gg/nodejs

cc @vcarl

@AugustinMauroy
Copy link
Member

For me it's work again

@avivkeller
Copy link
Member

Indeed, it's back up

@avivkeller avivkeller enabled auto-merge August 13, 2025 15:00
@avivkeller avivkeller added github_actions:pull-request Trigger Pull Request Checks and removed blocked labels Aug 13, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 13, 2025
@avivkeller avivkeller added this pull request to the merge queue Aug 13, 2025
Merged via the queue into main with commit cd078de Aug 13, 2025
25 checks passed
@avivkeller avivkeller deleted the MattIPv4/update-nodejs-invite branch August 13, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants