-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore: use discord.gg/nodejs for Discord invite #8069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Discord invitation links across the Node.js website to use the new vanity URL discord.gg/nodejs instead of the previous URL.
- Updates redirect configuration to use the new vanity URL
- Replaces direct Discord links in navigation and documentation
- Ensures consistent use of the canonical invite URL across all site content
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| redirects.json | Updates redirect rules for /discord paths to use new vanity URL |
| 2025-pride.md | Replaces direct Discord link in blog post with new vanity URL |
| official-discord-launch-announcement.md | Updates Discord links in announcement post to use new vanity URL |
| get-involved/index.md | Changes Discord server link in community involvement documentation |
| navigation.json | Updates Discord link in site navigation to use new vanity URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8069 +/- ##
==========================================
+ Coverage 72.80% 72.81% +0.01%
==========================================
Files 96 96
Lines 8328 8328
Branches 214 214
==========================================
+ Hits 6063 6064 +1
+ Misses 2264 2263 -1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Two open questions from me on this:
|
|
Lighthouse Results
|
In general we don't update translation. @bmuenzenmeyer do you have the permission to force changes on crowdin ? |
Since it is just the link, yes.
Delete the pages. |
38bb69a to
80aea23
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM !
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Marking this as blocked -- discord.gg/nodejs appears to suddenly no longer be working again |
RafaelGSS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link LGTM
cc @vcarl |
|
For me it's work again |
|
Indeed, it's back up |
Description
We've finally got the vanity invite URL, discord.gg/nodejs, so let's use that as the canonical invite on the site.
Validation
Links to join the Discord server still work.
Related Issues
N/A
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.